From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Milton Miller <miltonm@bga.com>
Cc: Olaf Hering <olaf@aepfle.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
ppcdev <linuxppc-dev@ozlabs.org>
Subject: Re:
Date: Fri, 13 Apr 2007 12:23:21 +1000 [thread overview]
Message-ID: <1176431001.5764.51.camel@localhost.localdomain> (raw)
In-Reply-To: <91308d2b933e4fe8a9618aef8748b878@bga.com>
On Thu, 2007-04-12 at 10:44 -0500, Milton Miller wrote:
> Matt sealey wrote:
>
> + if (cb & 0x5) { /* if controller is configured for
> pci-native mode for both channels */
>
> The above expression allows 1, 4, or 5 for the masked bits. I'm
> guessing you
> wanted to test that equal to either 5 or 0.
I think the proper test is ((cb & 5) == 5) but I can't remember for
sure..
Ben.
next prev parent reply other threads:[~2007-04-13 2:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 15:44 Milton Miller
2007-04-13 2:23 ` Benjamin Herrenschmidt [this message]
2007-04-13 18:45 ` Segher Boessenkool
2007-04-13 18:59 ` Re: Sergei Shtylyov
2007-04-13 19:10 ` Re: Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2022-04-05 21:41 rcu_sched self-detected stall on CPU Miguel Ojeda
2022-04-06 9:31 ` Zhouyi Zhou
2022-04-06 17:00 ` Paul E. McKenney
2022-04-08 7:23 ` Michael Ellerman
2022-04-08 14:42 ` Michael Ellerman
2022-04-13 5:11 ` Nicholas Piggin
2022-04-22 15:53 ` Thomas Gleixner
2022-04-23 2:29 ` Re: Nicholas Piggin
2019-08-30 19:54 [PATCH] Revert "asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro" Arnd Bergmann
[not found] ` <20190830202959.3539-1-msuchanek@suse.de>
2019-08-30 20:32 ` Arnd Bergmann
[not found] <1287422825-14999-1-git-send-email-nacc@us.ibm.com>
2010-10-18 17:26 ` [PATCH 1/7] microblaze: pci-common cleanup Nishanth Aravamudan
2010-10-20 5:31 ` Michal Simek
2010-11-01 6:29 ` Re: Michal Simek
2010-08-18 20:56 Wolfgang Denk
2010-08-19 1:04 ` Stephen Rothwell
2010-09-02 6:14 ` Re: Wolfgang Denk
2010-09-02 14:51 ` Rupjyoti Sarmah
2010-09-07 6:29 ` RE: Rupjyoti Sarmah
2009-07-23 14:38 Solomon Peachy
2009-07-26 23:38 ` Benjamin Herrenschmidt
2008-08-21 6:21 Schmid Alexander
2008-08-21 9:48 ` Wolfgang Denk
2008-01-02 18:16 Re: rsa
2007-11-01 18:18 Mead, Joseph
2007-11-01 19:07 ` Grant Likely
2007-11-02 9:35 ` MingLiu
2007-04-27 19:15 Mead, Joseph
2007-04-27 20:30 ` Scott Coulter
1999-05-18 7:26 nicolas.boussekeyt
1999-05-18 18:03 ` Alex Vallens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176431001.5764.51.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).