From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Fix PowerPC 750CL CPU features
Date: Fri, 13 Apr 2007 12:28:30 +1000 [thread overview]
Message-ID: <1176431310.5764.54.camel@localhost.localdomain> (raw)
In-Reply-To: <aeef7937e978aec33074251c48dca389@kernel.crashing.org>
> The difference between these two is
>
> #define CPU_FTRS_750GX (CPU_FTR_DUAL_PLL_750FX | CPU_FTR_HAS_HIGH_BATS)
> #define CPU_FTRS_750 (CPU_FTR_COMMON)
>
> 750GX excludes COMMON, which seems like a bug. With
> your change, 750CL uses DUAL_PLL_750FX; does it actually
> have that feature?
Looks indeed like that lack of COMMON in the GX entry is a bug...
Josh, care to fix that too while at it ? :-)
> Either way, it seems a good idea to create a CPU_FTRS_750CL,
> the CL is an evolution of the CX, not the FX/GX (in name
> at least, dunno about the gory details).
Agreed.
> > - .cpu_setup = __setup_cpu_750cx,
> > + .cpu_setup = __setup_cpu_750fx,
>
> Same thing here. Are you sure 750CL doesn't need
> the NAP workaround? [Is anyone sure the 750CX
> actually needs it -- the comment in cpu_setup_6xx.S
> doesn't instill much confidence.]
Agreed too.
Ben.
next prev parent reply other threads:[~2007-04-13 2:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 12:49 [PATCH] powerpc: Fix PowerPC 750CL CPU features Josh Boyer
2007-04-12 13:49 ` Milton Miller
2007-04-12 13:53 ` Josh Boyer
2007-04-12 16:41 ` Segher Boessenkool
2007-04-12 17:06 ` Kumar Gala
2007-04-12 17:11 ` Josh Boyer
2007-04-12 17:10 ` Josh Boyer
2007-04-12 19:24 ` Segher Boessenkool
2007-04-13 2:28 ` Benjamin Herrenschmidt [this message]
2007-04-13 10:52 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176431310.5764.54.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).