From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
scsi <linux-scsi@vger.kernel.org>, gregkh <greg@kroah.com>,
David Somayajulu <david.somayajulu@qlogic.com>,
linuxppc-dev@ozlabs.org,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
linux-driver@qlogic.com, PCI <linux-pci@atrey.karlin.mff.cuni.cz>
Subject: Re: qla_wxyz pci_set_mwi question
Date: Fri, 13 Apr 2007 12:34:22 +1000 [thread overview]
Message-ID: <1176431662.5764.56.camel@localhost.localdomain> (raw)
In-Reply-To: <20070412200438.GM26692@parisc-linux.org>
On Thu, 2007-04-12 at 14:04 -0600, Matthew Wilcox wrote:
> On Thu, Apr 12, 2007 at 12:37:13PM -0700, Andrew Vasquez wrote:
> > On Thu, 12 Apr 2007, Matthew Wilcox wrote:
> > > Why should it fail? If there's a platform which can't support a
> > > cacheline size that the qla2xyz card can handle, it should be able to
> > > happily fall back to doing plain writes instead of MWIs. IMO, it should
> > > just call pci_set_mwi() and ignore the result.
> >
> > I believe there were some erratas on some ISP2xxx chips where MWI
> > needed to be set for proper operation. I'll go back, verify and
> > update the patch accordingly.
>
> Hmm. The thing is that pci_set_mwi() returns success on machines where
> MWI is disabled (currently only PPC64). Perhaps it needs to fail
> instead.
MWI isn't diabled on ppc64... or did I miss something ?
Ben.
next prev parent reply other threads:[~2007-04-13 2:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070411221507.69c97257.randy.dunlap@oracle.com>
[not found] ` <20070412172038.GG10124@andrew-vasquezs-computer.local>
[not found] ` <20070412185347.GL26692@parisc-linux.org>
[not found] ` <20070412193713.GB14510@andrew-vasquezs-computer.local>
2007-04-12 20:04 ` qla_wxyz pci_set_mwi question Matthew Wilcox
2007-04-13 2:34 ` Benjamin Herrenschmidt [this message]
2007-04-13 2:40 ` Randy Dunlap
2007-04-13 2:43 ` Benjamin Herrenschmidt
2007-05-03 17:44 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176431662.5764.56.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=andrew.vasquez@qlogic.com \
--cc=david.somayajulu@qlogic.com \
--cc=greg@kroah.com \
--cc=linux-driver@qlogic.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=matthew@wil.cx \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).