linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@freescale.com>
To: Jerry Van Baren <gvb.uboot@gmail.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Jon Loeliger <jdl@jdl.com>,
	u-boot-users <u-boot-users@lists.sourceforge.net>
Subject: Re: [PATCH: dtc take 2] Assemble the blob in memory before writing it out.
Date: Thu, 19 Apr 2007 13:27:22 -0500	[thread overview]
Message-ID: <1177007241.14328.21.camel@ld0161-tx32> (raw)
In-Reply-To: <20070419015951.GA9339@dellserver.lan>

On Wed, 2007-04-18 at 20:59, Jerry Van Baren wrote:
> This makes padding out the blob if the user requested extra size much
> easer.  The assembly and writing to the file is more straight forward too.
> 
> Signed-off-by: Gerald Van Baren <vanbaren@cideas.com>
> ---
> 
> Hi David, Jon,
> 
> I wasn't happy with David's suggestion on the -S handling.  I also wasn't
> all that wild about how the blob was assembled and then written to the
> file piecemeal with "ad-hoc" alignment padding.  I realized I could fix
> both by assembling the blob in memory as a "struct data" and then write
> the whole thing out in one fell swoop.
> 
> Makes it a lot simpler and cleaner to my eyes.
> 
> Hope y'all agree,
> gvb

Jerry and David,

Sorry.  I've been out sick for a couple days here and am
just now catching up.  I've read through the last week's
worth of mail here now, so let me see if I have properly
summarized where things stand and what's needed for the DTC:

These patches need to be applied:

    [PATCH dtc] Add -o <output file> to the usage message.
    Sat, 14 Apr 2007 18:16:47 -0400

    [PATCH dtc take 3] Fix reserve map output for asm format.
    Tue, 17 Apr 2007 18:14:41 -0400

    [PATCH: dtc take 2] Assemble the blob in memory before writing it out.
    Wed, 18 Apr 2007 21:59:51 -0400

The last patch there replaces the "Improve -S handling" patches.
But does the last patch replace or depend on the second one?

And I agree with David that last patch is a better approach.

Thanks,
jdl

  parent reply	other threads:[~2007-04-19 18:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-19  1:59 [PATCH: dtc take 2] Assemble the blob in memory before writing it out Jerry Van Baren
2007-04-19  2:05 ` David Gibson
2007-04-19 18:27 ` Jon Loeliger [this message]
2007-04-19 18:49   ` [U-Boot-Users] " Jerry Van Baren
2007-04-19 19:03     ` Jon Loeliger
2007-04-19 22:31     ` Jon Loeliger
2007-04-19 23:45       ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1177007241.14328.21.camel@ld0161-tx32 \
    --to=jdl@freescale.com \
    --cc=gvb.uboot@gmail.com \
    --cc=jdl@jdl.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=u-boot-users@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).