From: David Woodhouse <dwmw2@infradead.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 13/14] powerpc: add ps3 platform system bus support
Date: Tue, 01 May 2007 07:44:11 +0100 [thread overview]
Message-ID: <1178001851.3085.137.camel@pmac.infradead.org> (raw)
In-Reply-To: <20070430155823.GA30344@aepfle.de>
On Mon, 2007-04-30 at 17:58 +0200, Olaf Hering wrote:
> On Mon, Apr 30, Geoff Levand wrote:
>
> > > The generated modalias files do not match anything.
> >
> > Module support is still todo. I am just now started on it. David
> > Woodhouse sent a few patches, but I just merged them in without
> > testing.
>
> This is my version, compile tested.
I have no particular objection to this, but would observe that it's more
normal to have the number->name mapping done in userspace by modprobe,
rather than inside the kernel.
For now I'd just added explicit aliases like 'MODULE_ALIAS("ps3:3");' to
the modules in question, because I hadn't yet worked out how to do all
the mod_devicetable stuff to pick it out of the match_id in the driver
structure.
--
dwmw2
next prev parent reply other threads:[~2007-05-01 6:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 4:21 [PATCH 13/14] powerpc: add ps3 platform system bus support Geoff Levand
2007-04-30 10:47 ` Olaf Hering
2007-04-30 15:49 ` Geoff Levand
2007-04-30 15:58 ` Olaf Hering
2007-05-01 6:44 ` David Woodhouse [this message]
2007-05-01 23:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178001851.3085.137.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).