From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from canuck.infradead.org (canuck.infradead.org [209.217.80.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id CBE6ADDF9E for ; Tue, 1 May 2007 16:44:21 +1000 (EST) Subject: Re: [PATCH 13/14] powerpc: add ps3 platform system bus support From: David Woodhouse To: Olaf Hering In-Reply-To: <20070430155823.GA30344@aepfle.de> References: <4563D02F.9010307@am.sony.com> <20070430104714.GA25815@aepfle.de> <4636100C.7020006@am.sony.com> <20070430155823.GA30344@aepfle.de> Content-Type: text/plain Date: Tue, 01 May 2007 07:44:11 +0100 Message-Id: <1178001851.3085.137.camel@pmac.infradead.org> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2007-04-30 at 17:58 +0200, Olaf Hering wrote: > On Mon, Apr 30, Geoff Levand wrote: > > > > The generated modalias files do not match anything. > > > > Module support is still todo. I am just now started on it. David > > Woodhouse sent a few patches, but I just merged them in without > > testing. > > This is my version, compile tested. I have no particular objection to this, but would observe that it's more normal to have the number->name mapping done in userspace by modprobe, rather than inside the kernel. For now I'd just added explicit aliases like 'MODULE_ALIAS("ps3:3");' to the modules in question, because I hadn't yet worked out how to do all the mod_devicetable stuff to pick it out of the match_id in the driver structure. -- dwmw2