Re: [PATCH] powerpc: fix suspend states again

Olof Johansson
2007-04-27T21:53:11Z

Hi,

On Fri, Apr 27, 2007 at 11:41:35PM +0200, Johannes Berg wrote:

> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ linux-2.6/arch/powerpc/kernel/swsusp.c 2007-04-27 23:25:20.406021121 +0200
> @@ -0,0 +1,42 @@
> +/*
> + * Common powerpc suspend code for 32 and 64 bits
> + *
> + * Copyright 2007 Johannes Berg <johannes@sipsolutions.net>
> + *
> + * GPLv2
> + */

A regular GPL copyright blurb isn't that hard to paste in. :-)

> +#include <linux/sched.h>
> +#include <asm/suspend.h>
> +#include <asm/cputable.h>
> +#include <asm/system.h>
> +#include <asm/current.h>
> +#include <asm/mmu_context.h>
> +
> +#ifdef CONFIG_SPE
> +extern void enable_kernel_spe(void);
> +#endif

This should be added to asm-powerpc/system.h instead, and that should
be included here since that has the enable_kernel_altivec() and
enable_kernel_fp() definitions.

-Olof