From: Michael Ellerman <michael@ellerman.id.au>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/5] powerpc: generic time suspend/resume code
Date: Wed, 02 May 2007 15:02:23 +1000 [thread overview]
Message-ID: <1178082143.5296.9.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <20070319105357.964696000@sipsolutions.net>
[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]
On Mon, 2007-03-19 at 11:53 +0100, Johannes Berg wrote:
> plain text document attachment (001-time-resume.patch)
> This patch removes the time suspend/restore code that was done through
> a PMU notifier in arch/platforms/powermac/time.c.
>
> Instead, introduce arch/powerpc/sysdev/timer.c which creates a sys
> device and handles time of day suspend/resume through that.
>
> This should probably be replaced by using the generic RTC framework
> but for now it gets rid of the arcane powermac specific hack.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This seems to break prep_defconfig:
timer.c:(.text+0x28c): undefined reference to `rtc_tm_to_time'
timer.c:(.text+0x38c): undefined reference to `rtc_tm_to_time'
make[1]: *** [.tmp_vmlinux1] Error 1
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-05-02 5:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 10:53 [PATCH 0/5] powermac suspend fixes Johannes Berg
2007-03-19 10:53 ` [PATCH 1/5] powerpc: generic time suspend/resume code Johannes Berg
2007-03-19 14:47 ` Benjamin Herrenschmidt
2007-03-19 21:51 ` Guennadi Liakhovetski
2007-03-19 22:11 ` Johannes Berg
2007-03-19 23:21 ` Guennadi Liakhovetski
2007-03-21 20:47 ` David Brownell
2007-03-21 22:48 ` Guennadi Liakhovetski
2007-05-02 5:02 ` Michael Ellerman [this message]
2007-05-02 8:25 ` Johannes Berg
2007-05-02 11:06 ` Michael Ellerman
2007-05-02 14:04 ` Johannes Berg
2007-03-19 10:53 ` [PATCH 2/5] powerpc: fix suspend states again Johannes Berg
2007-03-19 14:48 ` Benjamin Herrenschmidt
2007-03-19 15:22 ` Johannes Berg
2007-03-19 15:32 ` Benjamin Herrenschmidt
2007-03-19 15:45 ` Johannes Berg
2007-03-19 15:54 ` Johannes Berg
2007-03-19 16:22 ` Johannes Berg
2007-03-19 16:39 ` Benjamin Herrenschmidt
2007-03-19 16:06 ` Benjamin Herrenschmidt
2007-03-19 10:53 ` [PATCH 3/5] powermac: disallow pmu sleep notifiers from aborting sleep Johannes Berg
2007-03-19 14:49 ` Benjamin Herrenschmidt
2007-03-19 10:53 ` [PATCH 4/5] powermac: proper sleep management Johannes Berg
2007-03-19 14:50 ` Benjamin Herrenschmidt
2007-03-19 15:16 ` Johannes Berg
2007-03-19 23:44 ` Johannes Berg
2007-03-20 0:11 ` [PATCH 4/5 v2] " Johannes Berg
2007-03-20 0:48 ` Johannes Berg
2007-03-20 2:19 ` Johannes Berg
2007-03-19 10:53 ` [PATCH 5/5] remove dead code in via-pmu68k Johannes Berg
2007-03-19 19:17 ` Brad Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178082143.5296.9.camel@concordia.ozlabs.ibm.com \
--to=michael@ellerman.id.au \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).