linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH] via-pmu: kill sleep notifiers completely
Date: Wed, 02 May 2007 08:18:30 +0200	[thread overview]
Message-ID: <1178086710.13233.23.camel@johannes.berg> (raw)
In-Reply-To: <17969.56735.644629.328360@cargo.ozlabs.ibm.com>

This patch kills off the remnants of the ancient sleep notifiers.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>

---
Obviously depends on the previous patches that remove all the users.

 drivers/macintosh/via-pmu.c |   71 --------------------------------------------
 include/linux/pmu.h         |   36 ----------------------
 2 files changed, 107 deletions(-)

--- wireless-dev.orig/drivers/macintosh/via-pmu.c	2007-05-02 07:24:43.429196053 +0200
+++ wireless-dev/drivers/macintosh/via-pmu.c	2007-05-02 08:15:04.959192713 +0200
@@ -177,7 +177,6 @@ static struct proc_dir_entry *proc_pmu_b
 
 int __fake_sleep;
 int asleep;
-BLOCKING_NOTIFIER_HEAD(sleep_notifier_list);
 
 #ifdef CONFIG_ADB
 static int adb_dev_map;
@@ -1738,67 +1737,7 @@ pmu_present(void)
 	return via != 0;
 }
 
-#ifdef CONFIG_PM
-
-static LIST_HEAD(sleep_notifiers);
-
-int
-pmu_register_sleep_notifier(struct pmu_sleep_notifier *n)
-{
-	struct list_head *list;
-	struct pmu_sleep_notifier *notifier;
-
-	for (list = sleep_notifiers.next; list != &sleep_notifiers;
-	     list = list->next) {
-		notifier = list_entry(list, struct pmu_sleep_notifier, list);
-		if (n->priority > notifier->priority)
-			break;
-	}
-	__list_add(&n->list, list->prev, list);
-	return 0;
-}
-EXPORT_SYMBOL(pmu_register_sleep_notifier);
-
-int
-pmu_unregister_sleep_notifier(struct pmu_sleep_notifier* n)
-{
-	if (n->list.next == 0)
-		return -ENOENT;
-	list_del(&n->list);
-	n->list.next = NULL;
-	return 0;
-}
-EXPORT_SYMBOL(pmu_unregister_sleep_notifier);
-#endif /* CONFIG_PM */
-
 #if defined(CONFIG_PM) && defined(CONFIG_PPC32)
-
-/* Sleep is broadcast last-to-first */
-static void broadcast_sleep(int when)
-{
-	struct list_head *list;
-	struct pmu_sleep_notifier *notifier;
-
-	for (list = sleep_notifiers.prev; list != &sleep_notifiers;
-	     list = list->prev) {
-		notifier = list_entry(list, struct pmu_sleep_notifier, list);
-		notifier->notifier_call(notifier, when);
-	}
-}
-
-/* Wake is broadcast first-to-last */
-static void broadcast_wake(void)
-{
-	struct list_head *list;
-	struct pmu_sleep_notifier *notifier;
-
-	for (list = sleep_notifiers.next; list != &sleep_notifiers;
-	     list = list->next) {
-		notifier = list_entry(list, struct pmu_sleep_notifier, list);
-		notifier->notifier_call(notifier, PBOOK_WAKE);
-	}
-}
-
 /*
  * This struct is used to store config register values for
  * PCI devices which may get powered off when we sleep.
@@ -2003,9 +1942,6 @@ pmac_suspend_devices(void)
 
 	pm_prepare_console();
 	
-	/* Notify old-style device drivers */
-	broadcast_sleep(PBOOK_SLEEP_REQUEST);
-
 	/* Sync the disks. */
 	/* XXX It would be nice to have some way to ensure that
 	 * nobody is dirtying any new buffers while we wait. That
@@ -2014,12 +1950,9 @@ pmac_suspend_devices(void)
 	 */
 	sys_sync();
 
-	broadcast_sleep(PBOOK_SLEEP_NOW);
-
 	/* Send suspend call to devices, hold the device core's dpm_sem */
 	ret = device_suspend(PMSG_SUSPEND);
 	if (ret) {
-		broadcast_wake();
 		printk(KERN_ERR "Driver sleep failed\n");
 		return -EBUSY;
 	}
@@ -2060,7 +1993,6 @@ pmac_suspend_devices(void)
 		local_irq_enable();
 		preempt_enable();
 		device_resume();
-		broadcast_wake();
 		printk(KERN_ERR "Driver powerdown failed\n");
 		return -EBUSY;
 	}
@@ -2114,9 +2046,6 @@ pmac_wakeup_devices(void)
 	/* Resume devices */
 	device_resume();
 
-	/* Notify old style drivers */
-	broadcast_wake();
-
 	pm_restore_console();
 
 	return 0;
--- wireless-dev.orig/include/linux/pmu.h	2007-05-02 07:24:24.169196053 +0200
+++ wireless-dev/include/linux/pmu.h	2007-05-02 07:24:43.569196053 +0200
@@ -159,42 +159,6 @@ extern void pmu_unlock(void);
 extern int pmu_present(void);
 extern int pmu_get_model(void);
 
-#ifdef CONFIG_PM
-/*
- * Stuff for putting the powerbook to sleep and waking it again.
- *
- */
-#include <linux/list.h>
-
-struct pmu_sleep_notifier
-{
-	void (*notifier_call)(struct pmu_sleep_notifier *self, int when);
-	int priority;
-	struct list_head list;
-};
-
-/* Code values for calling sleep/wakeup handlers
- */
-#define PBOOK_SLEEP_REQUEST	1
-#define PBOOK_SLEEP_NOW		2
-#define PBOOK_WAKE		3
-
-/* priority levels in notifiers */
-#define SLEEP_LEVEL_VIDEO	100	/* Video driver (first wake) */
-#define SLEEP_LEVEL_MEDIABAY	90	/* Media bay driver */
-#define SLEEP_LEVEL_BLOCK	80	/* IDE, SCSI */
-#define SLEEP_LEVEL_NET		70	/* bmac, gmac */
-#define SLEEP_LEVEL_MISC	60	/* Anything else */
-#define SLEEP_LEVEL_USERLAND	55	/* Reserved for apm_emu */
-#define SLEEP_LEVEL_ADB		50	/* ADB (async) */
-#define SLEEP_LEVEL_SOUND	40	/* Sound driver (blocking) */
-
-/* special register notifier functions */
-int pmu_register_sleep_notifier(struct pmu_sleep_notifier* notifier);
-int pmu_unregister_sleep_notifier(struct pmu_sleep_notifier* notifier);
-
-#endif /* CONFIG_PM */
-
 #define PMU_MAX_BATTERIES	2
 
 /* values for pmu_power_flags */

  parent reply	other threads:[~2007-05-02  8:15 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-27 11:25 patches for 2.6.22 Paul Mackerras
2007-04-27 12:00 ` Johannes Berg
2007-04-27 21:41 ` [PATCH] powerpc: fix suspend states again Johannes Berg
2007-04-27 21:53   ` Olof Johansson
2007-04-27 21:54     ` Johannes Berg
2007-04-27 21:57       ` Olof Johansson
2007-04-27 22:00       ` [PATCH] powerpc: put enable_kernel_spe into a header Johannes Berg
2007-04-27 22:02       ` [PATCH v2] powerpc: fix suspend states again Johannes Berg
2007-04-27 23:13         ` Olof Johansson
2007-04-30  0:14         ` Paul Mackerras
2007-04-30 11:35           ` Johannes Berg
2007-04-30 11:37           ` [PATCH v3] " Johannes Berg
2007-05-01 14:16             ` Johannes Berg
2007-04-27 23:42 ` patches for 2.6.22 Arnd Bergmann
2007-04-28  2:49 ` [PATCH] cell: cbe_cpufreq cleanup and crash fix Arnd Bergmann
2007-04-28  7:49 ` [PATCH] powermac: proper sleep management Johannes Berg
2007-04-28  8:08   ` Paul Mackerras
2007-04-28 12:52     ` Johannes Berg
2007-04-28  8:38   ` Benjamin Herrenschmidt
2007-04-28 12:51     ` Johannes Berg
2007-04-28 12:01   ` Paul Mackerras
2007-04-28 13:46     ` Johannes Berg
2007-04-30  5:31       ` Paul Mackerras
2007-04-30 12:08         ` Johannes Berg
2007-05-01 12:14           ` Paul Mackerras
2007-05-01 12:24             ` Johannes Berg
2007-04-30 11:44   ` [PATCH v3] " Johannes Berg
2007-05-01  8:55     ` Johannes Berg
2007-04-30 19:51 ` patches for 2.6.22 Kim Phillips
2007-05-01  3:38   ` Paul Mackerras
2007-05-02 14:12   ` Kumar Gala
2007-05-02 14:19     ` Kim Phillips
2007-05-01  9:06 ` Johannes Berg
2007-05-02  5:33 ` [PATCH] adb: replace sleep notifier with platform driver suspend/resume hooks Johannes Berg
2007-05-02  5:34 ` [PATCH] apm_emu: use generic apm-emulation Johannes Berg
2007-05-02  5:36 ` [PATCH] via-pmu: remove LED sleep notifier Johannes Berg
2007-05-02 10:57   ` Stephen Rothwell
2007-05-02 14:32     ` [PATCH v2] " Johannes Berg
2007-05-07  8:47       ` Paul Mackerras
2007-05-07  8:58         ` Johannes Berg
2007-05-07 15:08         ` [PATCH v3] " Johannes Berg
2007-05-02  5:39 ` [PATCH] remove awacs dmasound Johannes Berg
2007-05-02  6:18 ` Johannes Berg [this message]
2007-05-02  6:21 ` [PATCH] powermac: support G5 CPU hotplug Johannes Berg
2007-05-02 10:55   ` Paul Mackerras
2007-05-02 14:33     ` Johannes Berg
2007-05-02 17:57       ` Segher Boessenkool
2007-05-02 22:03       ` Benjamin Herrenschmidt
2007-05-02 23:47         ` Segher Boessenkool
2007-05-02 23:59           ` Benjamin Herrenschmidt
2007-05-03  0:05             ` Segher Boessenkool
2007-05-03  0:18               ` Benjamin Herrenschmidt
2007-05-03  0:01         ` Paul Mackerras
2007-05-03  0:08           ` Benjamin Herrenschmidt
2007-05-03  0:10             ` Benjamin Herrenschmidt
2007-05-03  0:19             ` Segher Boessenkool
2007-05-03  0:17           ` Segher Boessenkool
2007-05-03  0:21             ` Benjamin Herrenschmidt
2007-05-03  0:24               ` Benjamin Herrenschmidt
2007-05-03  1:01               ` Segher Boessenkool
2007-05-03  2:11                 ` Benjamin Herrenschmidt
2007-05-03 16:49                   ` Segher Boessenkool
2007-05-02 20:33     ` [PATCH v2] " Johannes Berg
2007-05-02  6:33 ` [PATCH] powerpc: MPIC sys_device & suspend/resume Johannes Berg
2007-05-02  6:35 ` [PATCH] powermac: fix G5-cpufreq for cpu on/offline Johannes Berg
2007-05-03 12:25 ` patches for 2.6.22 Johannes Berg
2007-05-03 12:28   ` [PATCH] powerpc: dart iommu suspend Johannes Berg
2007-05-03 12:30     ` Benjamin Herrenschmidt
2007-05-03 12:34       ` Johannes Berg
2007-05-03 12:34         ` Benjamin Herrenschmidt
2007-05-03 12:48       ` Johannes Berg
2007-05-03 14:24         ` Olof Johansson
2007-05-04 10:51           ` Johannes Berg
2007-05-03 12:29   ` [PATCH] powerpc: mark pages that don't exist as nosave Johannes Berg
2007-05-03 12:31   ` [PATCH] powermac: suspend to disk on G5 Johannes Berg
2007-07-17 13:28 ` [PATCH] remove awacs dmasound Johannes Berg
2007-07-17 13:37   ` Adrian Bunk
2007-07-17 13:43     ` Johannes Berg
  -- strict thread matches above, loose matches on Subject: below --
2007-07-17 13:29 [PATCH] via-pmu: kill sleep notifiers completely Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1178086710.13233.23.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).