Re: [PATCH 1/5] powerpc: generic time suspend/resume code

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

On Wed, 2007-05-02 at 10:25 +0200, Johannes Berg wrote:
> On Wed, 2007-05-02 at 15:02 +1000, Michael Ellerman wrote:
> 
> > This seems to break prep_defconfig:
> > 
> > timer.c:(.text+0x28c): undefined reference to `rtc_tm_to_time'
> > timer.c:(.text+0x38c): undefined reference to `rtc_tm_to_time'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> 
> Odd. I put this into Kconfig:
> config PPC_PM_NEEDS_RTC_LIB
>         bool
>         select RTC_LIB
>         default y if PM
> 
> and that should cause the rtc lib that contains the rtc_tm_to_time
> function to be compiled in if you have PM enabled (and otherwise timer.c
> isn't compiled). Or maybe defconfig doesn't invoke oldconfig?

Ah sorry, I didn't mention prep_defconfig is arch/__ppc__. 

See arch/ppc/Makefile:

core-y                          += arch/ppc/kernel/ arch/powerpc/kernel/ \
                                   arch/ppc/platforms/ \
                                   arch/ppc/mm/ arch/ppc/lib/ \
                                   arch/ppc/syslib/ arch/powerpc/sysdev/ \
                                   arch/powerpc/lib/


So I guess we need to add the Kconfig fragment on arch/ppc also?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]