From: Will Schmidt <will_schmidt@vnet.ibm.com>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org,
Kevin Corry <kevcorry@us.ibm.com>
Subject: [PATCH 2/1] comment fixup for smp_call_function
Date: Thu, 03 May 2007 16:47:09 -0500 [thread overview]
Message-ID: <1178228829.7871.112.camel@farscape.rchland.ibm.com> (raw)
In-Reply-To: <1178153638.5338.2.camel@concordia.ozlabs.ibm.com>
Fix up the comment blob for smp_call_function and friends. Also just a
touch of whitespace cleanup.
Signed-off-by: Will Schmidt <will_schmidt@vnet.ibm.com>
---
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 4878588..1b82228 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -176,15 +176,13 @@ static struct call_data_struct {
#define SMP_CALL_TIMEOUT 8
/*
- * These functions send a 'generic call function' IPI to other online
- * CPUS in the system.
+ * smp_call_function(): Run a function on other CPUs.
+ * @func: The function to run. This must be fast and non-blocking.
+ * @info: An arbitrary pointer to pass to the function.
+ * @nonatomic: currently unused.
+ * @wait: If true, wait (atomically) until function has completed on other CPUs.
*
- * [SUMMARY] Run a function on other CPUs.
- * <func> The function to run. This must be fast and non-blocking.
- * <info> An arbitrary pointer to pass to the function.
- * <nonatomic> currently unused.
- * <wait> If true, wait (atomically) until function has completed on other CPUs.
- * [RETURNS] 0 on success, else a negative status code. Does not return until
+ * Returns 0 on success, else a negative status code. Does not return until
* remote CPUs are nearly ready to execute <<func>> or are or have executed.
*
* You must not call this function with disabled interrupts or from a
@@ -361,7 +359,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
DBG("smp_prepare_cpus\n");
- /*
+ /*
* setup_cpu may need to be called on the boot cpu. We havent
* spun any cpus up but lets be paranoid.
*/
@@ -375,7 +373,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
max_cpus = smp_ops->probe();
else
max_cpus = 1;
-
+
smp_space_timers(max_cpus);
for_each_possible_cpu(cpu)
@@ -585,7 +583,7 @@ void __init smp_cpus_done(unsigned int max_cpus)
*/
old_mask = current->cpus_allowed;
set_cpus_allowed(current, cpumask_of_cpu(boot_cpuid));
-
+
if (smp_ops)
smp_ops->setup_cpu(boot_cpuid);
prev parent reply other threads:[~2007-05-03 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 17:12 [PATCH] add smp_call_function_map and smp_call_function_single Will Schmidt
2007-05-03 0:53 ` Michael Ellerman
2007-05-03 21:47 ` Will Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178228829.7871.112.camel@farscape.rchland.ibm.com \
--to=will_schmidt@vnet.ibm.com \
--cc=anton@samba.org \
--cc=kevcorry@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).