From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Nathan Lynch <ntl@pobox.com>, paulus@samba.org
Subject: Re: [PATCH v4 4/7] Add support for 750CL Holly board
Date: Wed, 09 May 2007 09:47:36 +1000 [thread overview]
Message-ID: <1178668056.14928.132.camel@localhost.localdomain> (raw)
In-Reply-To: <1178643686.3453.37.camel@zod.rchland.ibm.com>
> > +
> > > + tsi_pic = of_find_node_by_type(NULL, "open-pic");
> > > + if (tsi_pic) {
> > > + unsigned int size;
> > > + const void *prop = of_get_property(tsi_pic, "reg", &size);
> > > + mpic_paddr = of_translate_address(tsi_pic, prop);
> > > + }
> >
> > You don't actually need 'size' there; it's legal to pass NULL to
> > of_get_property.
Probably easier to use of_address_to_resource
Ben.
next prev parent reply other threads:[~2007-05-08 23:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 21:22 [PATCH v4 0/7] Add support for 750CL Holly board Josh Boyer
2007-05-07 21:25 ` [PATCH v4 1/7] Add tsi108_pci.h for common PCI functions Josh Boyer
2007-05-08 1:15 ` Olof Johansson
2007-05-07 21:26 ` [PATCH v4 2/7] Generalize tsi108 PHY types Josh Boyer
2007-05-08 1:15 ` Olof Johansson
2007-05-07 21:27 ` [PATCH v4 3/7] Generalize tsi108 PCI setup Josh Boyer
2007-05-08 1:16 ` Olof Johansson
2007-05-07 21:28 ` [PATCH v4 4/7] Add support for 750CL Holly board Josh Boyer
2007-05-08 1:21 ` Olof Johansson
2007-05-08 16:45 ` Nathan Lynch
2007-05-08 17:01 ` Josh Boyer
2007-05-08 23:47 ` Benjamin Herrenschmidt [this message]
2007-05-07 21:29 ` [PATCH v4 5/7] Holly defconfig Josh Boyer
2007-05-07 21:31 ` [PATCH v4 6/7] Holly DTS Josh Boyer
2007-05-07 21:32 ` [PATCH v4 7/7] Holly bootwrapper Josh Boyer
2007-05-08 0:16 ` David Gibson
2007-05-08 1:07 ` Josh Boyer
2007-05-08 1:07 ` David Gibson
2007-05-08 3:45 ` [PATCH v4 0/7] Add support for 750CL Holly board Zang Roy-r61911
2007-05-08 10:46 ` Josh Boyer
2007-05-08 13:49 ` Zang Roy-r61911
2007-05-09 2:19 ` Zang Roy-r61911
2007-05-09 2:34 ` Josh Boyer
2007-05-09 2:52 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1178668056.14928.132.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).