Re: [PATCH 1/4] Add support for 750CL Holly board

[Josh Boyer <jwboyer@linux.vnet.ibm.com>]

On Wed, 2007-05-09 at 09:19 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2007-05-04 at 21:44 +0200, Arnd Bergmann wrote:
> 
> > > +void holly_show_cpuinfo(struct seq_file *m)
> > > +{
> > > +	seq_printf(m, "vendor\t\t: IBM\n");
> > > +	seq_printf(m, "machine\t\t: PPC750 GX/CL\n");
> > > +}
> > 
> > If it's an IBM product, it should come with a product code like 123-4567,
> > which fits in here, instead of just listing the CPU.
> 
> Should probably come from the device tree anyway.

It will with some cleanup patches I'm planning on.

> > > +	const struct exception_table_entry *entry;
> > > +
> > > +	/* Are we prepared to handle this fault */
> > > +	if ((entry = search_exception_tables(regs->nip)) != NULL) {
> > > +		tsi108_clear_pci_cfg_error();
> > > +		regs->msr |= MSR_RI;
> > > +		regs->nip = entry->fixup;
> > > +		return 1;
> > > +	}
> > > +	return 0;
> > > +}
> > 
> > Are you sure that you can use the generic exception table mechanism
> > like this? I can't see why it doesn't work, but it's something I haven't
> > seen anyone do like this.
> 
> Also, can't the TSI be configured to not generate MCE in that case ?

Not that I'm aware of.  They should only occur on the initial PCI bus
scan.

josh