* [PATCH 3/3] stop_machine() now uses hard_irq_disable
@ 2007-05-10 5:25 Benjamin Herrenschmidt
2007-05-10 5:33 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2007-05-10 5:25 UTC (permalink / raw)
To: linux-kernel, linuxppc-dev; +Cc: Andrew Morton, Rusty Russell
Add a call to hard_irq_disable() to stop_machine so that we make sure
IRQs are really disabled and not only lazy-disabled on archs like
powerpc as some users of stop_machine() may rely on that.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
kernel/stop_machine.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-cell/kernel/stop_machine.c
===================================================================
--- linux-cell.orig/kernel/stop_machine.c 2007-05-10 14:46:08.000000000 +1000
+++ linux-cell/kernel/stop_machine.c 2007-05-10 14:47:12.000000000 +1000
@@ -45,6 +45,7 @@ static int stopmachine(void *cpu)
if (stopmachine_state == STOPMACHINE_DISABLE_IRQ
&& !irqs_disabled) {
local_irq_disable();
+ hard_irq_disable();
irqs_disabled = 1;
/* Ack: irqs disabled. */
smp_mb(); /* Must read state first. */
@@ -124,6 +125,7 @@ static int stop_machine(void)
/* Make them disable irqs. */
local_irq_disable();
+ hard_irq_disable();
stopmachine_set_state(STOPMACHINE_DISABLE_IRQ);
return 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] stop_machine() now uses hard_irq_disable
2007-05-10 5:25 [PATCH 3/3] stop_machine() now uses hard_irq_disable Benjamin Herrenschmidt
@ 2007-05-10 5:33 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2007-05-10 5:33 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Andrew Morton, linux-kernel
On Thu, 2007-05-10 at 15:25 +1000, Benjamin Herrenschmidt wrote:
> Add a call to hard_irq_disable() to stop_machine so that we make sure
> IRQs are really disabled and not only lazy-disabled on archs like
> powerpc as some users of stop_machine() may rely on that.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-10 5:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-10 5:25 [PATCH 3/3] stop_machine() now uses hard_irq_disable Benjamin Herrenschmidt
2007-05-10 5:33 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).