From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linuxppc-dev@ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>, Anton Blanchard <anton@samba.org>
Subject: Re: [RFC/PATCH] powerpc: Rewrite IO allocation & mapping on powerpc64
Date: Mon, 14 May 2007 19:18:40 +1000 [thread overview]
Message-ID: <1179134321.32247.88.camel@localhost.localdomain> (raw)
In-Reply-To: <20070514075415.7999BDDEC8@ozlabs.org>
> + /* If this not a PHB, we don't do anything on mapping */
> + if (bus->self) {
> + DBG("IO mapping for PCI-PCI bridge %s\n",
> + pci_name(bus->self));
> + DBG(" virt=0x%016lx...0x%016lx\n",
> + bus->resource[0]->start + pci_io_base,
> + bus->resource[0]->end + pci_io_base);
> + return 0;
> }
Hrm... the above is incorrect. Since I iounmap_at() when removing a P2P
bridge, I need to ioremap_at() when mapping it back in. I'll fix that
in the next iteration.
One of the cool thing is that mapping over a previous mapping is
harmless, so if the PHB is inserted and create a mapping for the full
PHB range, and later on, a P2P is added to this PHB, doing an
ioremap_at() will work fine wether that sub-range was part of the
initial PHB mapping or wether it was unmapped by a previous removal of a
bridge...
Ben.
next prev parent reply other threads:[~2007-05-14 9:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 7:53 [RFC/PATCH] powerpc: Rewrite IO allocation & mapping on powerpc64 Benjamin Herrenschmidt
2007-05-14 7:59 ` Benjamin Herrenschmidt
2007-05-14 8:03 ` Benjamin Herrenschmidt
2007-05-14 9:18 ` Benjamin Herrenschmidt [this message]
2007-05-14 13:50 ` Segher Boessenkool
2007-05-14 20:53 ` Benjamin Herrenschmidt
2007-05-15 0:17 ` Paul Mackerras
2007-05-15 4:33 ` Segher Boessenkool
2007-05-15 6:04 ` Benjamin Herrenschmidt
2007-05-14 14:37 ` Arnd Bergmann
2007-05-14 15:04 ` Segher Boessenkool
2007-05-14 23:56 ` Arnd Bergmann
2007-05-15 0:05 ` Olof Johansson
2007-05-14 20:59 ` Benjamin Herrenschmidt
2007-05-14 23:39 ` Arnd Bergmann
2007-05-15 0:06 ` Benjamin Herrenschmidt
2007-05-15 10:56 ` Christoph Hellwig
2007-05-15 20:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179134321.32247.88.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).