From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: Small fixes for the Ebony device tree
Date: Mon, 14 May 2007 10:09:28 -0500 [thread overview]
Message-ID: <1179155368.3420.30.camel@zod.rchland.ibm.com> (raw)
In-Reply-To: <3af16d1a6c09901f10dca3b6a3f8c698@kernel.crashing.org>
On Mon, 2007-05-14 at 14:59 +0200, Segher Boessenkool wrote:
> > - i-cache-size = <0>;
> > - d-cache-size = <0>;
> > + i-cache-size = <2000000>; /* 32 kB */
> > + d-cache-size = <2000000>; /* 32 kB */
>
> That's 32MB, not 32kB. Better fix this :-)
Argh. What's even sadder is I just did the exact same thing for Bamboo.
> > + SRAM0: sram {
> > + compatible = "ibm,sram440gp";
> > + dcr-reg = <020 8 00a 1>;
> > + };
>
> Is this thing _only_ addressable over DCRs? Weird.
Yes.
>
> > MAL0: mcmal {
> > - device_type = "mcmal-dma";
> > + device_type = "dma-controller";
> > compatible = "ibm,mcmal-440gp", "ibm,mcmal";
>
> Remove "device_type", change name to "dma-controller"?
>
> > EBC0: ebc {
> > - device_type = "ibm,ebc";
> > compatible = "ibm,ebc-440gp";
>
> You forgot "ibm,ebc" here.
/me notes that for Bamboo
josh
next prev parent reply other threads:[~2007-05-14 15:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-14 4:54 Small fixes for the Ebony device tree David Gibson
2007-05-14 12:22 ` Josh Boyer
2007-05-14 12:59 ` Segher Boessenkool
2007-05-14 15:09 ` Josh Boyer [this message]
2007-05-15 1:17 ` David Gibson
2007-05-15 4:59 ` Segher Boessenkool
2007-05-15 5:46 ` David Gibson
2007-05-16 3:47 ` David Gibson
2007-05-15 18:15 ` Mark A. Greer
-- strict thread matches above, loose matches on Subject: below --
2007-05-15 2:00 David Gibson
2007-05-15 5:11 ` Segher Boessenkool
2007-05-15 5:47 ` David Gibson
2007-05-15 6:11 ` Stefan Roese
2007-05-15 6:18 ` David Gibson
2007-05-15 6:28 ` Segher Boessenkool
2007-05-15 6:34 ` David Gibson
2007-05-15 6:47 ` Segher Boessenkool
2007-05-15 6:58 ` David Gibson
2007-05-15 7:07 ` Segher Boessenkool
2007-05-16 3:47 ` David Gibson
2007-05-15 6:46 ` Stefan Roese
2007-05-15 7:02 ` Segher Boessenkool
2007-05-16 3:48 David Gibson
2007-05-16 13:35 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179155368.3420.30.camel@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).