From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org,
Dominik Brodowski <linux@dominikbrodowski.net>,
linuxppc-dev@ozlabs.org, paulus@samba.org,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t
Date: Tue, 15 May 2007 08:47:04 +1000 [thread overview]
Message-ID: <1179182824.32247.131.camel@localhost.localdomain> (raw)
In-Reply-To: <20070514150802.b9120e9f.akpm@linux-foundation.org>
On Mon, 2007-05-14 at 15:08 -0700, Andrew Morton wrote:
>
> Well that's some pretty sad code you've found there. The kernel
> surely has
> some appropriate type to use here without us having to invent a new
> one.
> But I suspect if we were to rationalise things in there it will get
> messy.
There is more sad stuff involved with drivers assuming IO ports fit in
int. A proper fix for 2.6.23 will be the rework of PIO allocation I'm
doing. A temporary fix for 2.6.22 would be for Olof to use
reserve_phb_iospace() to make sure his PIO gets in the low 31 bits. We
need to add a spinlock to it though.
Ben.
next prev parent reply other threads:[~2007-05-14 22:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 14:31 [PATCH] pcmcia: ppc64 needs 64-bit ioaddr_t Olof Johansson
2007-05-13 21:22 ` Olof Johansson
2007-05-13 21:46 ` Christoph Hellwig
2007-05-14 22:57 ` Olof Johansson
2007-05-15 5:52 ` Christoph Hellwig
2007-05-14 22:08 ` Andrew Morton
2007-05-14 22:47 ` Benjamin Herrenschmidt [this message]
2007-05-14 22:59 ` Olof Johansson
2007-05-15 4:33 ` [PATCH v2] pcmcia: ppc64 needs 32-bit ioaddr_t Olof Johansson
2007-05-15 7:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179182824.32247.131.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).