From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: Fix warning in pci_64.c
Date: Tue, 15 May 2007 16:03:33 +1000 [thread overview]
Message-ID: <1179209013.32247.147.camel@localhost.localdomain> (raw)
In-Reply-To: <20070515143042.987cba34.sfr@canb.auug.org.au>
On Tue, 2007-05-15 at 14:30 +1000, Stephen Rothwell wrote:
> On Tue, 15 May 2007 14:16:35 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > void pcibios_add_platform_entries(struct pci_dev *pdev)
> > {
> > - device_create_file(&pdev->dev, &dev_attr_devspec);
> > + int rc = device_create_file(&pdev->dev, &dev_attr_devspec);
> > + WARN_ON(rc != 0);
>
> If we really don't care if the file is not created, then it is probably
> worth a comment as to why ...
Well, if it's not created, then something is badly wrong thus a
WARN_ON ... Do you think I should do more ?
Ben.
next prev parent reply other threads:[~2007-05-15 6:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 4:16 [PATCH] powerpc: Fix warning in pci_64.c Benjamin Herrenschmidt
2007-05-15 4:30 ` Stephen Rothwell
2007-05-15 6:03 ` Michael Ellerman
2007-05-15 6:03 ` Benjamin Herrenschmidt [this message]
2007-05-15 8:22 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179209013.32247.147.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).