From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] powerpc: Fix IO space on PCI busses created from of_platform
Date: Wed, 16 May 2007 06:46:09 +1000 [thread overview]
Message-ID: <1179261969.32247.195.camel@localhost.localdomain> (raw)
In-Reply-To: <200705151524.39805.arnd.bergmann@de.ibm.com>
On Tue, 2007-05-15 at 15:24 +0200, Arnd Bergmann wrote:
>
> I think this still needs some logic to make sure we have at least one
> primary PHB in the system. On a board that has all phbs probed by
> of_platform code, we never set the pci_io_base variable.
Point, I need to fix that too.
> The easiest solution might be to statically initialize pci_io_base
> to PHBS_IO_BASE. If it is different from that, we are already broken
> because we would get _negative_ I/O port numbers for PHBs below
> pci_io_base.
If we do that we need to clear it in iSeries code though.
Ben.
prev parent reply other threads:[~2007-05-15 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 4:16 [PATCH 2/2] powerpc: Fix IO space on PCI busses created from of_platform Benjamin Herrenschmidt
2007-05-15 4:26 ` Olof Johansson
2007-05-15 13:24 ` Arnd Bergmann
2007-05-15 20:46 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179261969.32247.195.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=arnd.bergmann@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox