linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linuxppc-dev@ozlabs.org, Greg KH <greg@kroah.com>
Subject: Re: [viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal]
Date: Wed, 16 May 2007 10:49:48 +1000	[thread overview]
Message-ID: <1179276588.4120.22.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <20070515194729.GE4095@ftp.linux.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

On Tue, 2007-05-15 at 20:47 +0100, Al Viro wrote:
> [oops - typo in Cc in original posting]
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  drivers/pci/hotplug/rpadlpar_sysfs.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c
> index 6c5be3f..df07606 100644
> --- a/drivers/pci/hotplug/rpadlpar_sysfs.c
> +++ b/drivers/pci/hotplug/rpadlpar_sysfs.c
> @@ -129,8 +129,9 @@ struct kobj_type ktype_dlpar_io = {
>  };
>  
>  struct kset dlpar_io_kset = {
> -	.subsys = &pci_hotplug_slots_subsys,
> -	.kobj = {.name = DLPAR_KOBJ_NAME, .ktype=&ktype_dlpar_io,},
> +	.kobj = {.name = DLPAR_KOBJ_NAME,
> +		 .ktype = &ktype_dlpar_io,
> +		 .parent = &pci_hotplug_slots_subsys.kobj},
>  	.ktype = &ktype_dlpar_io,
>  };

That seems to work, I get 'add_slot' and 'remove_slot'
under /sys/bus/pci/slots/control again.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-05-16  0:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-15 19:47 [viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal] Al Viro
2007-05-16  0:49 ` Michael Ellerman [this message]
2007-05-16  6:57   ` Benjamin Herrenschmidt
2007-05-16  7:15     ` Greg KH
2007-05-16 21:22 ` John Rose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179276588.4120.22.camel@concordia.ozlabs.ibm.com \
    --to=michael@ellerman.id.au \
    --cc=greg@kroah.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).