[viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal]

[viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal]

[Al Viro]

[oops - typo in Cc in original posting]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/pci/hotplug/rpadlpar_sysfs.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c
index 6c5be3f..df07606 100644
--- a/drivers/pci/hotplug/rpadlpar_sysfs.c
+++ b/drivers/pci/hotplug/rpadlpar_sysfs.c
@@ -129,8 +129,9 @@ struct kobj_type ktype_dlpar_io = {
 };
 
 struct kset dlpar_io_kset = {
-	.subsys = &pci_hotplug_slots_subsys,
-	.kobj = {.name = DLPAR_KOBJ_NAME, .ktype=&ktype_dlpar_io,},
+	.kobj = {.name = DLPAR_KOBJ_NAME,
+		 .ktype = &ktype_dlpar_io,
+		 .parent = &pci_hotplug_slots_subsys.kobj},
 	.ktype = &ktype_dlpar_io,
 };
 
-- 
1.5.0-rc2.GIT


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

----- End forwarded message -----

Re: [viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal]

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

On Tue, 2007-05-15 at 20:47 +0100, Al Viro wrote:
> [oops - typo in Cc in original posting]
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  drivers/pci/hotplug/rpadlpar_sysfs.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_sysfs.c b/drivers/pci/hotplug/rpadlpar_sysfs.c
> index 6c5be3f..df07606 100644
> --- a/drivers/pci/hotplug/rpadlpar_sysfs.c
> +++ b/drivers/pci/hotplug/rpadlpar_sysfs.c
> @@ -129,8 +129,9 @@ struct kobj_type ktype_dlpar_io = {
>  };
>  
>  struct kset dlpar_io_kset = {
> -	.subsys = &pci_hotplug_slots_subsys,
> -	.kobj = {.name = DLPAR_KOBJ_NAME, .ktype=&ktype_dlpar_io,},
> +	.kobj = {.name = DLPAR_KOBJ_NAME,
> +		 .ktype = &ktype_dlpar_io,
> +		 .parent = &pci_hotplug_slots_subsys.kobj},
>  	.ktype = &ktype_dlpar_io,
>  };

That seems to work, I get 'add_slot' and 'remove_slot'
under /sys/bus/pci/slots/control again.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal]

[Benjamin Herrenschmidt]

> That seems to work, I get 'add_slot' and 'remove_slot'
> under /sys/bus/pci/slots/control again.

I verified that PCI hotplug actually works with that patch.

Ben.

Re: [viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal]

[Greg KH]

On Wed, May 16, 2007 at 04:57:09PM +1000, Benjamin Herrenschmidt wrote:
> 
> > That seems to work, I get 'add_slot' and 'remove_slot'
> > under /sys/bus/pci/slots/control again.
> 
> I verified that PCI hotplug actually works with that patch.

Thanks for testing, and Al, thanks for the patch, the rpadlpar code was
doing something different from what I expected...

thanks,

greg k-h

Re: [viro@ftp.linux.org.uk: [PATCH] rpadlpar breakage - fallout of struct subsystem removal]

[John Rose]

> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Verified boot, hotplug, and dynamic add/remove of buses.  Perfect,
thanks Al!

Acked-by: John Rose <johnrose@austin.ibm.com>