[PATCH] powerpc: Fix VDSO compile warning

[PATCH] powerpc: Fix VDSO compile warning

[Segher Boessenkool]

Maybe the type should have been char[] instead of __u8[]
in the first place, but this will do.

Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
---
 arch/powerpc/kernel/vdso.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c
index 4245579..cef01e4 100644
--- a/arch/powerpc/kernel/vdso.c
+++ b/arch/powerpc/kernel/vdso.c
@@ -670,7 +670,7 @@ static int __init vdso_init(void)
 	/*
 	 * Fill up the "systemcfg" stuff for backward compatiblity
 	 */
-	strcpy(vdso_data->eye_catcher, "SYSTEMCFG:PPC64");
+	strcpy((char *)vdso_data->eye_catcher, "SYSTEMCFG:PPC64");
 	vdso_data->version.major = SYSTEMCFG_MAJOR;
 	vdso_data->version.minor = SYSTEMCFG_MINOR;
 	vdso_data->processor = mfspr(SPRN_PVR);
-- 
1.5.2.rc0.g4342-dirty

Re: [PATCH] powerpc: Fix VDSO compile warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

On Wed, 16 May 2007 17:12:16 +0200 Segher Boessenkool <segher@kernel.crashing.org> wrote:
>
> Maybe the type should have been char[] instead of __u8[]
> in the first place, but this will do.

What warning do you get?  What compiler version?

I don't get a warning using version 4.1.2 20061115 (prerelease) (Debian
4.1.1-21).

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] powerpc: Fix VDSO compile warning

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

On Thu, 17 May 2007 11:27:04 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> I don't get a warning using version 4.1.2 20061115 (prerelease) (Debian
> 4.1.1-21).

Actually, version 4.1.3 20070429 (prerelease) (Debian 4.1.2-5)

(Damn distcc :-))

--
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] powerpc: Fix VDSO compile warning

[Segher Boessenkool]

>> Maybe the type should have been char[] instead of __u8[]
>> in the first place, but this will do.
>
> What warning do you get?

Oh sorry, should have mentioned that:

arch/powerpc/kernel/vdso.c: In function 'vdso_init':
arch/powerpc/kernel/vdso.c:673: warning: passing argument
	1 of 'strcpy' from incompatible pointer type

> What compiler version?

GCC mainline of two days ago.


Segher