LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH] [POWERPC] Comment out a currently unused function
Date: Mon, 21 May 2007 17:19:30 +1000	[thread overview]
Message-ID: <1179731970.5579.0.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <20070521154026.640320cd.sfr@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Mon, 2007-05-21 at 15:40 +1000, Stephen Rothwell wrote:
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/macintosh/windfarm_smu_sat.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> 
> diff --git a/drivers/macintosh/windfarm_smu_sat.c b/drivers/macintosh/windfarm_smu_sat.c
> index 1043b39..42b767a 100644
> --- a/drivers/macintosh/windfarm_smu_sat.c
> +++ b/drivers/macintosh/windfarm_smu_sat.c
> @@ -400,10 +400,12 @@ static int __init sat_sensors_init(void)
>  	return i2c_add_driver(&wf_sat_driver);
>  }
>  
> +#if 0	/* uncomment when module_exit() below is uncommented */
>  static void __exit sat_sensors_exit(void)
>  {
>  	i2c_del_driver(&wf_sat_driver);
>  }
> +#endif

Why not remove it? You can always get it back with git.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2007-05-21  7:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21  5:40 [PATCH] [POWERPC] Comment out a currently unused function Stephen Rothwell
2007-05-21  7:19 ` Michael Ellerman [this message]
2007-05-21  7:36   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2007-08-15  6:54 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179731970.5579.0.camel@concordia.ozlabs.ibm.com \
    --to=michael@ellerman.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox