* [PATCH] powerpc: Fix powerpc vmlinux.lds.S
@ 2007-05-22 4:33 Benjamin Herrenschmidt
2007-05-22 15:01 ` Will Schmidt
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2007-05-22 4:33 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev list
Sam's recent changes broke things for us, some stuff sneaked in before
the entry point. In fact, we don't need that *(.text.*) thing anymore
and it incorrectly matched .text.init.refok, thus putting it
before .text. .. ouch !
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Index: linux-work/arch/powerpc/kernel/vmlinux.lds.S
===================================================================
--- linux-work.orig/arch/powerpc/kernel/vmlinux.lds.S 2007-05-22 14:16:39.000000000 +1000
+++ linux-work/arch/powerpc/kernel/vmlinux.lds.S 2007-05-22 14:19:00.000000000 +1000
@@ -34,7 +34,6 @@ SECTIONS
/* Text and gots */
.text : {
_text = .;
- *(.text.*)
TEXT_TEXT
SCHED_TEXT
LOCK_TEXT
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Fix powerpc vmlinux.lds.S
2007-05-22 4:33 [PATCH] powerpc: Fix powerpc vmlinux.lds.S Benjamin Herrenschmidt
@ 2007-05-22 15:01 ` Will Schmidt
2007-05-22 20:24 ` Kim Phillips
0 siblings, 1 reply; 3+ messages in thread
From: Will Schmidt @ 2007-05-22 15:01 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list, Paul Mackerras
On Tue, 2007-22-05 at 14:33 +1000, Benjamin Herrenschmidt wrote:
> Sam's recent changes broke things for us, some stuff sneaked in before
> the entry point. In fact, we don't need that *(.text.*) thing anymore
> and it incorrectly matched .text.init.refok, thus putting it
> before .text. .. ouch !
.. Which manifests itself on some systems as a hang after
"returning from prom_init".
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applying this makes my systems happy again... :-)
Acked-by: Will Schmidt <will_schmidt@vnet.ibm.com>
> ---
>
> Index: linux-work/arch/powerpc/kernel/vmlinux.lds.S
> ===================================================================
> --- linux-work.orig/arch/powerpc/kernel/vmlinux.lds.S 2007-05-22 14:16:39.000000000 +1000
> +++ linux-work/arch/powerpc/kernel/vmlinux.lds.S 2007-05-22 14:19:00.000000000 +1000
> @@ -34,7 +34,6 @@ SECTIONS
> /* Text and gots */
> .text : {
> _text = .;
> - *(.text.*)
> TEXT_TEXT
> SCHED_TEXT
> LOCK_TEXT
>
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: Fix powerpc vmlinux.lds.S
2007-05-22 15:01 ` Will Schmidt
@ 2007-05-22 20:24 ` Kim Phillips
0 siblings, 0 replies; 3+ messages in thread
From: Kim Phillips @ 2007-05-22 20:24 UTC (permalink / raw)
To: will_schmidt; +Cc: paulus, linuxppc-dev
On Tue, 22 May 2007 10:01:44 -0500
Will Schmidt <will_schmidt@vnet.ibm.com> wrote:
> On Tue, 2007-22-05 at 14:33 +1000, Benjamin Herrenschmidt wrote:
> > Sam's recent changes broke things for us, some stuff sneaked in before
> > the entry point. In fact, we don't need that *(.text.*) thing anymore
> > and it incorrectly matched .text.init.refok, thus putting it
> > before .text. .. ouch !
>
> .. Which manifests itself on some systems as a hang after
> "returning from prom_init".
>
>
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Applying this makes my systems happy again... :-)
>
same here.
> Acked-by: Will Schmidt <will_schmidt@vnet.ibm.com>
>
Acked-by: Kim Phillips <kim.phillips@freescale.com>
Kim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-22 20:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-22 4:33 [PATCH] powerpc: Fix powerpc vmlinux.lds.S Benjamin Herrenschmidt
2007-05-22 15:01 ` Will Schmidt
2007-05-22 20:24 ` Kim Phillips
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).