[PATCH] powerpc: Fix powerpc vmlinux.lds.S

[PATCH] powerpc: Fix powerpc vmlinux.lds.S

[Benjamin Herrenschmidt]

Sam's recent changes broke things for us, some stuff sneaked in before
the entry point. In fact, we don't need that *(.text.*) thing anymore
and it incorrectly matched .text.init.refok, thus putting it
before .text. .. ouch !

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Index: linux-work/arch/powerpc/kernel/vmlinux.lds.S
===================================================================
--- linux-work.orig/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:16:39.000000000 +1000
+++ linux-work/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:19:00.000000000 +1000
@@ -34,7 +34,6 @@ SECTIONS
 	/* Text and gots */
 	.text : {
 		_text = .;
-		*(.text.*)
 		TEXT_TEXT
 		SCHED_TEXT
 		LOCK_TEXT

Re: [PATCH] powerpc: Fix powerpc vmlinux.lds.S

[Will Schmidt]

On Tue, 2007-22-05 at 14:33 +1000, Benjamin Herrenschmidt wrote:
> Sam's recent changes broke things for us, some stuff sneaked in before
> the entry point. In fact, we don't need that *(.text.*) thing anymore
> and it incorrectly matched .text.init.refok, thus putting it
> before .text. .. ouch !

..  Which manifests itself on some systems as a hang after 
"returning from prom_init".  


> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Applying this makes my systems happy again... :-)

Acked-by:  Will Schmidt <will_schmidt@vnet.ibm.com>


> ---
> 
> Index: linux-work/arch/powerpc/kernel/vmlinux.lds.S
> ===================================================================
> --- linux-work.orig/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:16:39.000000000 +1000
> +++ linux-work/arch/powerpc/kernel/vmlinux.lds.S	2007-05-22 14:19:00.000000000 +1000
> @@ -34,7 +34,6 @@ SECTIONS
>  	/* Text and gots */
>  	.text : {
>  		_text = .;
> -		*(.text.*)
>  		TEXT_TEXT
>  		SCHED_TEXT
>  		LOCK_TEXT
> 
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] powerpc: Fix powerpc vmlinux.lds.S

[Kim Phillips]

On Tue, 22 May 2007 10:01:44 -0500
Will Schmidt <will_schmidt@vnet.ibm.com> wrote:

> On Tue, 2007-22-05 at 14:33 +1000, Benjamin Herrenschmidt wrote:
> > Sam's recent changes broke things for us, some stuff sneaked in before
> > the entry point. In fact, we don't need that *(.text.*) thing anymore
> > and it incorrectly matched .text.init.refok, thus putting it
> > before .text. .. ouch !
> 
> ..  Which manifests itself on some systems as a hang after 
> "returning from prom_init".  
> 
> 
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> Applying this makes my systems happy again... :-)
> 
same here.

> Acked-by:  Will Schmidt <will_schmidt@vnet.ibm.com>
> 
Acked-by:  Kim Phillips <kim.phillips@freescale.com>

Kim