From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andy Fleming <afleming@freescale.com>
Cc: Alexandre Bounine <Alexandre.Bounine@tundra.com>,
David Gibson <david@gibson.dropbear.id.au>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: TSI ethernet PHY question
Date: Fri, 25 May 2007 08:51:24 +1000 [thread overview]
Message-ID: <1180047084.32247.1070.camel@localhost.localdomain> (raw)
In-Reply-To: <396FEEDC-99AB-4E25-9C80-A901923429B0@freescale.com>
> For instance, I think #1 might usually be workable by passing in PHY-
> specific flags, and letting the PHY driver deal with it in
> config_init. This might even be workable for the BCM5461A chip as
> mentioned above. You could define a BCM5461A_TXC_RXC_DELAY_DISABLE
> flag, and have the config_init code check for that flag and perform
> the necessary disable.
For powerpc, I have a solution at hand, it's the device-tree :-)
Any struct device in the system can have a device node pointer via the
dev_sysdata thingy I added recently. So we can have some code for
powerpc that properly hooks up the PHY to an (optional) device-node
which can then contains properties describing what kind of workarounds
need to be applied.
For example, we can have a txc-rxc-delay-disable property on Holly.
The problem is that of course the PHY driver will need some powerpc
specific code to go fetch that. An option would be to instead use flags
and have a piece of powerpc specific code that translates those
device-tree properties into flags so that other archs can use the flags
using their own ways of passing them in.
I'm not too hot with the flag stuff tho since those really need to be
defined per PHY model/family. But I suppose that's fair enough.
Ben.
next prev parent reply other threads:[~2007-05-24 22:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-23 7:03 TSI ethernet PHY question Benjamin Herrenschmidt
2007-05-23 13:43 ` Alexandre Bounine
2007-05-23 15:55 ` Segher Boessenkool
2007-05-23 22:52 ` Benjamin Herrenschmidt
2007-05-24 18:53 ` Andy Fleming
2007-05-24 22:51 ` Benjamin Herrenschmidt [this message]
2007-05-24 23:54 ` Segher Boessenkool
2007-05-25 0:01 ` Benjamin Herrenschmidt
2007-05-25 0:57 ` Segher Boessenkool
2007-05-25 1:53 ` Benjamin Herrenschmidt
2007-05-25 14:24 ` Segher Boessenkool
2007-05-25 6:02 ` Paul Mackerras
2007-05-25 14:25 ` Segher Boessenkool
2007-05-25 2:00 ` David Gibson
2007-05-25 7:35 ` Zang Roy-r61911
2007-05-25 14:17 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180047084.32247.1070.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Alexandre.Bounine@tundra.com \
--cc=afleming@freescale.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).