linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Olaf Hering <olaf@aepfle.de>
Cc: Geert.Uytterhoeven@sonycom.com, linuxppc-dev@ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 6/7] ps3: ROM Storage Driver
Date: Sat, 26 May 2007 08:45:19 +1000	[thread overview]
Message-ID: <1180133119.19517.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20070525112414.GA32336@aepfle.de>

On Fri, 2007-05-25 at 13:24 +0200, Olaf Hering wrote:
> On Fri, May 25, Geert.Uytterhoeven@sonycom.com wrote:
> 
> > +++ b/drivers/scsi/ps3rom.c
> 
> > +			kaddr = kmap_atomic(sgpnt->page, KM_USER0);
> 
> linux/highmem.h is not included to get the kmap_* prototypes.

Beside, I don't see the point of using kmap on ppc64...

Ben.

  reply	other threads:[~2007-05-25 22:45 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25  8:36 [patch 0/7] RFC: PS3 Storage Drivers Geert.Uytterhoeven
2007-05-25  8:36 ` [patch 1/7] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver Geert.Uytterhoeven
2007-05-25 22:35   ` Benjamin Herrenschmidt
2007-05-26  8:51     ` Geert Uytterhoeven
2007-05-26 22:17       ` Benjamin Herrenschmidt
2007-05-27 18:24         ` Arnd Bergmann
2007-05-25  8:36 ` [patch 2/7] ps3: Extract ps3_repository_find_bus() Geert.Uytterhoeven
2007-05-25  8:36 ` [patch 3/7] ps3: Storage Driver Core Geert.Uytterhoeven
2007-05-25  8:36 ` [patch 4/7] ps3: Storage Driver Probing Geert.Uytterhoeven
2007-05-25 16:18   ` Arnd Bergmann
2007-05-25 17:09     ` Geoff Levand
2007-05-25 19:48     ` Geert Uytterhoeven
2007-05-25 22:54       ` Benjamin Herrenschmidt
2007-05-25 22:47     ` Benjamin Herrenschmidt
2007-05-26  8:56       ` Geert Uytterhoeven
2007-05-25  8:36 ` [patch 5/7] ps3: Disk Storage Driver Geert.Uytterhoeven
2007-05-25 11:45   ` Olaf Hering
2007-05-25 19:43     ` Geert Uytterhoeven
2007-05-25 20:47       ` Olaf Hering
2007-05-25 16:26   ` Arnd Bergmann
2007-05-25 19:40     ` Geert Uytterhoeven
2007-05-25 20:43       ` Arnd Bergmann
2007-05-25 21:22         ` Geert Uytterhoeven
2007-05-25 22:45           ` Arnd Bergmann
2007-05-25 22:53       ` Benjamin Herrenschmidt
2007-05-25 22:48     ` Benjamin Herrenschmidt
2007-05-25  8:36 ` [patch 6/7] ps3: ROM " Geert.Uytterhoeven
2007-05-25 11:24   ` Olaf Hering
2007-05-25 22:45     ` Benjamin Herrenschmidt [this message]
2007-05-26  8:52       ` Geert Uytterhoeven
2007-05-26 22:18         ` Benjamin Herrenschmidt
2007-05-29  9:55           ` Christoph Hellwig
2007-05-25 16:50   ` Arnd Bergmann
2007-05-25 19:36     ` Geert Uytterhoeven
2007-05-25 21:04       ` Arnd Bergmann
2007-05-29 10:51         ` Christoph Hellwig
2007-05-29 10:49   ` Christoph Hellwig
2007-05-29 11:11     ` Geert Uytterhoeven
2007-05-29 11:31       ` Benjamin Herrenschmidt
2007-05-30 10:13       ` Christoph Hellwig
2007-05-30 11:45         ` Benjamin Herrenschmidt
2007-05-30 17:18           ` Geoff Levand
2007-05-29 16:21     ` Geert Uytterhoeven
2007-05-30 10:01       ` Christoph Hellwig
2007-05-25  8:36 ` [patch 7/7] ps3: FLASH " Geert.Uytterhoeven
2007-05-29  9:53   ` Christoph Hellwig
2007-05-29  9:57     ` Geert Uytterhoeven
2007-05-29 10:51       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1180133119.19517.11.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).