From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <dwg@au1.ibm.com>
Cc: Alexandre Bounine <Alexandre.Bounine@tundra.com>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: Fix problems with Holly's DT representation of ethernet PHYs
Date: Mon, 28 May 2007 11:38:37 +1000 [thread overview]
Message-ID: <1180316317.19517.51.camel@localhost.localdomain> (raw)
In-Reply-To: <20070527233031.GB23768@localhost.localdomain>
On Mon, 2007-05-28 at 09:30 +1000, David Gibson wrote:
> On Fri, May 25, 2007 at 04:11:59PM +0200, Segher Boessenkool wrote:
> > > Waah! Third time lucky?
> >
> > You wish :-)
> >
> > > - Second, the PHYs give only "bcm54xx" as a compatible
> > > property. This is unfortunate, because there are many bcm54xx PHY
> > > models, and they have differences which can matter. We add a more
> > > precise compatible string, giving the precise PHY model (bcm5461A in
> > > this case).
> >
> > You completely removed the "compatible" properties instead.
> > Bad idea.
>
> Um... weren't you the one that was just saying compatible properties
> aren't necessary if you can distinguish the hardware in other ways?
In that case however, the 54xx are fairly different from each other, so
please use something more specific.
Ben.
next prev parent reply other threads:[~2007-05-28 1:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 4:16 Fix problems with Holly's DT representation of ethernet PHYs David Gibson
2007-05-24 4:22 ` Kumar Gala
2007-05-24 5:59 ` David Gibson
2007-05-24 9:13 ` Segher Boessenkool
2007-05-24 13:44 ` Josh Boyer
2007-05-25 4:23 ` David Gibson
2007-05-25 4:37 ` David Gibson
2007-05-25 4:38 ` David Gibson
2007-05-25 14:03 ` Josh Boyer
2007-05-27 23:36 ` David Gibson
2007-05-25 14:11 ` Segher Boessenkool
2007-05-27 23:30 ` David Gibson
2007-05-28 1:38 ` Benjamin Herrenschmidt [this message]
2007-05-28 11:07 ` Segher Boessenkool
2007-05-28 11:15 ` Benjamin Herrenschmidt
2007-05-28 11:06 ` Segher Boessenkool
2007-05-29 4:47 ` David Gibson
2007-05-24 9:11 ` Segher Boessenkool
2007-05-24 13:45 ` Josh Boyer
2007-05-25 2:04 ` David Gibson
-- strict thread matches above, loose matches on Subject: below --
2007-05-29 6:05 David Gibson
2007-05-29 6:43 ` Segher Boessenkool
2007-05-29 14:19 ` Josh Boyer
2007-05-29 14:49 ` Segher Boessenkool
2007-05-29 19:29 ` Josh Boyer
2007-05-30 11:17 ` Benjamin Herrenschmidt
2007-05-30 11:32 ` David Gibson
2007-05-30 11:36 ` Segher Boessenkool
2007-05-30 13:48 ` Josh Boyer
2007-05-30 15:28 ` Segher Boessenkool
2007-05-31 5:54 ` Zang Roy-r61911
2007-05-30 1:26 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180316317.19517.51.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Alexandre.Bounine@tundra.com \
--cc=dwg@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).