Re: [PATCH] fix compile warning in pseries xics

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]

On Tue, 2007-05-29 at 15:50 +1000, Michael Neuling wrote:
> In 616883df78bd4b3fcdb6ddc39bd3d4cb902bfa32 request_irq was marked as
> __must_check so we must... er... check it.
> 
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> ---
> This is the only request_irq which is not checked in arch/powerpc
> 
>  arch/powerpc/platforms/pseries/xics.c |   13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> Index: linux-2.6-ozlabs/arch/powerpc/platforms/pseries/xics.c
> ===================================================================
> --- linux-2.6-ozlabs.orig/arch/powerpc/platforms/pseries/xics.c
> +++ linux-2.6-ozlabs/arch/powerpc/platforms/pseries/xics.c
> @@ -752,6 +752,7 @@ skip_gserver_check:
>  void xics_request_IPIs(void)
>  {
>  	unsigned int ipi;
> +	int t;
>  
>  	ipi = irq_create_mapping(xics_host, XICS_IPI);
>  	BUG_ON(ipi == NO_IRQ);
> @@ -762,11 +763,15 @@ void xics_request_IPIs(void)
>  	 */
>  	set_irq_handler(ipi, handle_percpu_irq);
>  	if (firmware_has_feature(FW_FEATURE_LPAR))
> -		request_irq(ipi, xics_ipi_action_lpar, IRQF_DISABLED,
> -			    "IPI", NULL);
> +		t = request_irq(ipi, xics_ipi_action_lpar, IRQF_DISABLED,
> +				"IPI", NULL);
>  	else
> -		request_irq(ipi, xics_ipi_action_direct, IRQF_DISABLED,
> -			    "IPI", NULL);
> +		t = request_irq(ipi, xics_ipi_action_direct, IRQF_DISABLED,
> +				"IPI", NULL);
> +	if (t)
> +		printk(KERN_ERR "Unable to request interrupt %d for IPI\n",
> +		       ipi);

or BUG() ?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]