Re: [PATCH] fix compile warning in pseries xics

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1380 bytes --]

On Tue, 2007-05-29 at 09:27 -0500, Olof Johansson wrote:
> On Tue, May 29, 2007 at 05:01:52PM +1000, Michael Neuling wrote:
> > @@ -762,11 +763,12 @@ void xics_request_IPIs(void)
> >  	 */
> >  	set_irq_handler(ipi, handle_percpu_irq);
> >  	if (firmware_has_feature(FW_FEATURE_LPAR))
> > -		request_irq(ipi, xics_ipi_action_lpar, IRQF_DISABLED,
> > -			    "IPI", NULL);
> > +		rc = request_irq(ipi, xics_ipi_action_lpar, IRQF_DISABLED,
> > +				"IPI", NULL);
> >  	else
> > -		request_irq(ipi, xics_ipi_action_direct, IRQF_DISABLED,
> > -			    "IPI", NULL);
> > +		rc = request_irq(ipi, xics_ipi_action_direct, IRQF_DISABLED,
> > +				"IPI", NULL);
> > +	BUG_ON(rc);
> 
> Is this late enough during boot that you actually get useful information
> out of a BUG()?  It might be better to spit out an error and keep on
> going if that's the case (I'm afraid I don't have hardware at hand to
> test with right now).

It's way late:

start_kernel()
  rest_init()
    kernel_init()
      smp_prepare_cpus()
        smp_ops->probe()
          smp_xics_probe()
            xics_request_IPIs()

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]