From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>
Subject: Re: [RFC/PATCH 2/5] powerpc: Cleanup ptrace bits
Date: Wed, 30 May 2007 21:24:41 +1000 [thread overview]
Message-ID: <1180524281.19517.259.camel@localhost.localdomain> (raw)
In-Reply-To: <1180475149.19517.209.camel@localhost.localdomain>
On Wed, 2007-05-30 at 07:45 +1000, Benjamin Herrenschmidt wrote:
> > It looks like GDB will expect VRSAVE at offset 33*16 (length 4
> bytes)
> > in the area returned by PTRACE_GETVRREGS, for both 32-bit and
> 64-bit
> > applications:
>
> I have to check exactly what's going on there, it might be correct in
> both cases, I just remember that the code did something subtely
> different but it might result in the same thing. I'll double check
> today.
It was indeed correct in both cases, it just stupidly did direct ulong
refs on 32 bits and cast to u32 on 64 bits, which I consolidated into a
single implementation that uses u32 for vrsave so it should work fine.
Ben.
next prev parent reply other threads:[~2007-05-30 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 6:45 [RFC/PATCH 2/5] powerpc: Cleanup ptrace bits Benjamin Herrenschmidt
2007-05-29 9:02 ` Benjamin Herrenschmidt
2007-05-29 13:19 ` Kumar Gala
2007-05-29 13:37 ` Ulrich Weigand
2007-05-29 21:45 ` Benjamin Herrenschmidt
2007-05-30 11:24 ` Benjamin Herrenschmidt [this message]
2007-05-29 13:23 ` Kumar Gala
2007-05-29 21:33 ` Benjamin Herrenschmidt
2007-06-01 21:22 ` Christoph Hellwig
2007-06-01 22:54 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180524281.19517.259.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).