From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH v2]: Fix e500 v2 core reboot bug
Date: 31 May 2007 11:40:52 +0800 [thread overview]
Message-ID: <1180582852.16155.18.camel@localhost.localdomain> (raw)
In-Reply-To: <976AFF56-7590-46B9-ADCA-4FA6673D4C9B@kernel.crashing.org>
On Wed, 2007-05-30 at 21:49, Kumar Gala wrote:
> >>>>> I'm not terrible happy with blindly writing to rstcr.
> >>>>>
> >>>> I can understand you.
> >>>> But I jut want to make things simple and workable.
> >>>> Any idea?
> >>>
> >>> one idea would be for us to add a property on the soc node.
> >>> Something like has-rstcr or something similar in a guts node?
> >> I have seen your suggestion before to add a property in device
> tree.
> >> But I still think the current implementation is simple.
> >
> > While it simple you are depending on the fact that a given
> > implementation may or may not have something at the particular
> > offset. Who knows if 8599 or some future part could put the 'cause
> > my part to smoke and self-destruct' at the same offset in the
> > future :)
> >
> >> Anyway, I can try your suggestion.
> >
> > I'm thinking have a guts block and putting a property in it makes
> the
> > most sense.
>
> After some discussion on IRC I think the following is the suggested
> node we should add in.
>
> guts@e00000 {
> compatible = "fsl,mpc8548-guts";
> reg = <e00000 1000>;
> fsl,has-rstcr;
> };
Great!
Roy
next prev parent reply other threads:[~2007-05-31 3:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-29 2:36 [PATCH v2]: Fix e500 v2 core reboot bug Zang Roy-r61911
2007-05-29 17:38 ` Andy Fleming
2007-05-29 19:29 ` Kumar Gala
2007-05-30 2:34 ` Zang Roy-r61911
2007-05-30 2:40 ` Kumar Gala
2007-05-30 5:46 ` Zang Roy-r61911
2007-05-30 12:25 ` Kumar Gala
2007-05-30 13:49 ` Kumar Gala
2007-05-30 15:21 ` Segher Boessenkool
2007-05-31 5:32 ` Zang Roy-r61911
2007-05-31 5:52 ` Benjamin Herrenschmidt
2007-05-31 3:40 ` Zang Roy-r61911 [this message]
2007-06-04 8:28 ` Zang Roy-r61911
2007-06-04 8:41 ` Segher Boessenkool
2007-06-04 9:01 ` Zang Roy-r61911
2007-06-04 10:37 ` Segher Boessenkool
2007-06-05 2:15 ` Zang Roy-r61911
2007-05-31 2:38 ` Zang Roy-r61911
2007-06-12 9:08 ` [PATCH v3]: " Zang Roy-r61911
2007-06-12 16:18 ` Timur Tabi
2007-06-13 4:44 ` Segher Boessenkool
2007-06-13 5:45 ` Zang Roy-r61911
2007-06-13 6:24 ` Zang Roy-r61911
2007-06-13 6:43 ` Zang Roy-r61911
2007-06-13 6:57 ` Segher Boessenkool
2007-06-13 7:04 ` Segher Boessenkool
2007-06-13 6:16 ` Zang Roy-r61911
2007-06-13 6:28 ` Segher Boessenkool
2007-06-13 6:31 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180582852.16155.18.camel@localhost.localdomain \
--to=tie-fei.zang@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).