From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/3] consolidate do_signal
Date: Mon, 04 Jun 2007 11:10:53 +1000 [thread overview]
Message-ID: <1180919453.31677.29.camel@localhost.localdomain> (raw)
In-Reply-To: <1180828765.14025.34.camel@localhost.localdomain>
On Sun, 2007-06-03 at 09:59 +1000, Benjamin Herrenschmidt wrote:
> > + if ((ka.sa.sa_flags & SA_ONSTACK) &&
> > + current->sas_ss_size && !
> on_sig_stack(regs->gpr[1]))
> > + newsp = current->sas_ss_sp +
> current->sas_ss_size;
> > + else
> > + newsp = regs->gpr[1];
>
> Hrm... some gratuituous differences in the signal stack handling.. I
> wonder if that hides a bug in one of the implementations...
Ok, so, that bit is actually a bit nicer on 64 bits, where there's a
get_sigframe() that handles this and is called by setup_rt_frame (which
you renamed to handle_rt_signal64).
(Though the actual implementation of get_sigframe() could use some
cleanup).
I'll do a patch on top of yours making that bit common.
Cheers,
Ben.
prev parent reply other threads:[~2007-06-04 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-02 10:21 [PATCH 3/3] consolidate do_signal Christoph Hellwig
2007-06-02 23:59 ` Benjamin Herrenschmidt
2007-06-04 1:10 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180919453.31677.29.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).