From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 7F1A6E04A1 for ; Mon, 4 Jun 2007 15:20:22 +1000 (EST) Subject: Re: [PATCH] [2.6.22] powerpc: uninline and export virq_to_hw() From: Benjamin Herrenschmidt To: Olof Johansson In-Reply-To: <20070604044704.GA27581@lixom.net> References: <20070604044704.GA27581@lixom.net> Content-Type: text/plain Date: Mon, 04 Jun 2007 15:20:10 +1000 Message-Id: <1180934410.31677.40.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, 2007-06-03 at 23:47 -0500, Olof Johansson wrote: > Uninline virq_to_hw and export it so modules can use it. The > alternative > would be to export the irq_map array instead, but it's an infrequently > called function, and keeping the array unexported seems considerably > cleaner. It's called in fairly hot IRQ code path (the PIC themselves use it) no ? Ben.