From: Jon Loeliger <jdl@freescale.com>
To: Milton Miller <miltonm@bga.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 8/8] Wrote quirk_mpc8641_transparent() to initialize bridge resources.
Date: Mon, 04 Jun 2007 14:32:35 -0500 [thread overview]
Message-ID: <1180985555.9632.31.camel@ld0161-tx32> (raw)
In-Reply-To: <bfe9571d7d435aa6f52ae8d9ec61a1d5@bga.com>
On Mon, 2007-06-04 at 00:55, Milton Miller wrote:
> This is totally unreadable. include/linux/pci_ids.h exists for a
> reason,
> please use it. At least the vendor should be in there.
>
> If you want to define the device id with the same naming convention
> but in the local source file, I won't object.
> Please use the (new) helper of_read_number in prom.h.
> milton
>
> PS: how about create instead of wrote in the subject?
All yup.
Thanks,
jdl
prev parent reply other threads:[~2007-06-04 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 17:49 [PATCH 8/8] Wrote quirk_mpc8641_transparent() to initialize bridge resources Jon Loeliger
2007-06-04 5:55 ` Milton Miller
2007-06-04 19:32 ` Jon Loeliger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180985555.9632.31.camel@ld0161-tx32 \
--to=jdl@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).