From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [patch 1/3] powerpc: fix pci_setup_phb_io_dynamic for pci_iomap From: Benjamin Herrenschmidt To: Arnd Bergmann In-Reply-To: <20070604181739.375615838@arndb.de> References: <20070604181438.569356702@arndb.de> <20070604181739.375615838@arndb.de> Content-Type: text/plain Date: Wed, 06 Jun 2007 17:05:30 +1000 Message-Id: <1181113530.31677.236.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, cbe-oss-dev@ozlabs.org, Arnd Bergmann List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2007-06-04 at 20:14 +0200, Arnd Bergmann wrote: > plain text document attachment (pci-iomap-fix-2.diff) > From: Arnd Bergmann > We had a problem on a system with only dynamically allocated > PCI buses (using of_pci_phb_driver) in combination with libata. > This setup ended up having no "primary" phb, which means > that pci_io_base never got initialized and all IO port > numbers are 64 bit numbers, which is larger than the > PIO_MASK limit. > > Signed-off-by: Arnd Bergmann Acked-by: Benjamin Herrenschmidt Paulus, that's a bug fix, should probably go into 2.6.22 > --- > Index: linux-2.6/arch/powerpc/kernel/of_platform.c > =================================================================== > --- linux-2.6.orig/arch/powerpc/kernel/of_platform.c > +++ linux-2.6/arch/powerpc/kernel/of_platform.c > @@ -433,7 +433,7 @@ static int __devinit of_pci_phb_probe(st > * Note also that we don't do ISA, this will also be fixed with a > * more massive rework. > */ > - pci_setup_phb_io(phb, 0); > + pci_setup_phb_io(phb, pci_io_base == 0); > > /* Init pci_dn data structures */ > pci_devs_phb_init_dynamic(phb); > > --