linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [patch 08/18] PS3: Kexec support
Date: Thu, 07 Jun 2007 12:54:06 +1000	[thread overview]
Message-ID: <1181184846.31677.277.camel@localhost.localdomain> (raw)
In-Reply-To: <1181183468.4166.5.camel@concordia.ozlabs.ibm.com>

On Thu, 2007-06-07 at 12:31 +1000, Michael Ellerman wrote:
> > >> +  pr_debug("%s:%d: cpu %u, virq %d\n", __func__, __LINE__,
> pd->cpu, virq);
> > >> +
> > >> +  local_irq_save(flags);
> > >> +  asm volatile(
> > >> +               "1:        ldarx %0,0,%3\n"
> > >> +               "andc      %0,%0,%2\n"
> > >> +               "stdcx.    %0,0,%3\n"
> > >> +               "bne-      1b"
> > >> +               : "=&r" (old), "+m" (*p)
> > >> +               : "r" (bit), "r" (p)
> > >> +               : "cc" );
> > >> +
> > >> +  lv1_did_update_interrupt_mask(pd->node, pd->cpu);
> > >> +  local_irq_restore(flags);
> > > 
> > > How is this different from set_bit() ?  (asm-powerpc/bitops.h)
> > > 
> > > ps. now that I see you're just moving this code around someone's
> > > probably already asked that question. 

Actually the above is clear_bit :-)

That would thus be something around the lines of:

 clear_bit(&pd->bmp.mask, 63 - virq);

Geoff, feel free to replace it with the clear_bit if you think it's
nicer that way :-) (and double check I didn't smoke crack when doing
the above conversion).

The other one in unmask would be set_bit() of course.

Ben.

  reply	other threads:[~2007-06-07  2:54 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070606024407.786638029@am.sony.com>
2007-06-06  2:59 ` [patch 01/18] Cell: Add spu shutdown method Geoff Levand
2007-06-06  4:08   ` Michael Ellerman
2007-06-06 14:41     ` André Detsch
2007-06-06  2:59 ` [patch 02/18] PS3: Rename IPI symbols Geoff Levand
2007-06-06  3:11   ` Stephen Rothwell
2007-06-06 14:48     ` Will Schmidt
2007-06-06 20:47       ` Geoff Levand
2007-06-06 20:49     ` Geoff Levand
2007-06-06  2:59 ` [patch 03/18] PS3: Use __maybe_unused Geoff Levand
2007-06-06  4:05   ` Michael Ellerman
2007-06-06 22:37     ` Geoff Levand
2007-06-06  2:59 ` [patch 04/18] PS3: Compare firmware version Geoff Levand
2007-06-06  2:59 ` [patch 05/18] PS3: Fix sparse warnings Geoff Levand
2007-06-06 14:21   ` Arnd Bergmann
2007-06-07 14:34     ` Geoff Levand
2007-06-08  5:59       ` Takao Shinohara
2007-06-06  2:59 ` [patch 06/18] PS3: Add support for HDMI RGB Full Range mode Geoff Levand
2007-06-06  3:00 ` [patch 07/18] PS3: Make ps3av.h usable from user space Geoff Levand
2007-06-06  7:46   ` Christoph Hellwig
2007-06-06 11:27     ` Geert Uytterhoeven
2007-06-06 16:44     ` Geoff Levand
2007-06-07 19:15       ` Christoph Hellwig
2007-06-06  3:00 ` [patch 08/18] PS3: Kexec support Geoff Levand
2007-06-06  4:01   ` Michael Ellerman
2007-06-06 21:55     ` Geoff Levand
2007-06-07  1:25       ` Stephen Rothwell
2007-06-07  1:33         ` Geoff Levand
2007-06-07  2:48           ` Stephen Rothwell
2007-06-07  2:31       ` Michael Ellerman
2007-06-07  2:54         ` Benjamin Herrenschmidt [this message]
2007-06-10  0:13           ` Geoff Levand
2007-06-09  8:17   ` [patch 08/18] PS3: Kexec support (and a tutoral on the kexec flow for 64 bit powerpc) Milton Miller
2007-06-09 22:47     ` Geoff Levand
2007-06-06  3:00 ` [patch 09/18] PS3: System-bus rework Geoff Levand
2007-06-06  6:43   ` Geert Uytterhoeven
2007-06-11  7:07   ` Milton Miller
2007-06-11 15:39     ` Geoff Levand
2007-06-11 15:45       ` Geert Uytterhoeven
2007-06-06  3:00 ` [patch 10/18] PS3: System-bus uevent Geoff Levand
2007-06-06  3:00 ` [patch 11/18] PS3: System-bus modinfo attribute Geoff Levand
2007-06-06  3:17   ` Stephen Rothwell
2007-06-06  3:00 ` [patch 12/18] PS3: Repository probe cleanups Geoff Levand
2007-06-06  3:01 ` [patch 13/18] PS3: USB system-bus rework Geoff Levand
2007-06-06  3:01 ` [patch 14/18] PS3: Vuart rework Geoff Levand
2007-06-06  3:01 ` [patch 15/18] PS3: System manager re-work Geoff Levand
2007-06-06  6:51   ` Geert Uytterhoeven
2007-06-06  3:01 ` [patch 16/18] PS3: Rework AV settings driver Geoff Levand
2007-06-06  6:49   ` Geert Uytterhoeven
2007-06-06  3:01 ` [patch 17/18] PS3: Frame buffer system-bus rework Geoff Levand
2007-06-06  6:51   ` Geert Uytterhoeven
2007-06-06 15:56     ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-06-06 23:08       ` Geoff Levand
2007-06-06 23:37         ` Antonino A. Daplas
2007-06-06  3:01 ` [patch 18/18] PS3: Device registration routines Geoff Levand
2007-06-06  6:57   ` Geert Uytterhoeven
2007-06-06 12:21   ` Geert Uytterhoeven
2007-06-06  3:04 ` [patch 13/18] PS3: USB system-bus rework Geoff Levand
2007-06-08 23:22   ` [patch] PS3: Fix USB return value Geoff Levand
2007-06-25  7:30     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181184846.31677.277.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).