From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wfarnsworth@mvista.com>
Received: from gateway-1237.mvista.com (gateway-1237.mvista.com
	[63.81.120.158]) by ozlabs.org (Postfix) with ESMTP id 38690DDEA0
	for <linuxppc-dev@ozlabs.org>; Fri,  8 Jun 2007 02:26:52 +1000 (EST)
Subject: Re: [PATCH] When checking I8042 io port, use
	of_find_compatible_node() instead of of_find_node_by_type()
From: Wade Farnsworth <wfarnsworth@mvista.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
In-Reply-To: <2a56a9d008269d393c68959f1804c21d@kernel.crashing.org>
References: <1181148145.5674.121.camel@rhino>
	<2a56a9d008269d393c68959f1804c21d@kernel.crashing.org>
Content-Type: text/plain
Date: Thu, 07 Jun 2007 09:26:50 -0700
Message-Id: <1181233610.5674.167.camel@rhino>
Mime-Version: 1.0
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

On Thu, 2007-06-07 at 15:05 +0200, Segher Boessenkool wrote:
> > In check_legacy_ioport(), instead of using of_find_node_by_type() to
> > find the 8042 node, use of_find_compatible_node() to find either the
> > keyboard or mouse node.
> 
> Why?
> 
> >  	switch(base_port) {
> >  	case I8042_DATA_REG:
> > -		np = of_find_node_by_type(NULL, "8042");
> > +		np = of_find_compatible_node(NULL, NULL, "pnpPNP,303");
> > +		if (!np)
> > +			np = of_find_compatible_node(NULL, NULL, "pnpPNP,f03");
> > +		if (np) {
> > +			parent = of_get_parent(np);
> > +			of_node_put(np);
> > +			np = parent;
> > +		}
> 
> This breaks other boards using 8042, if those exist --
> if this code is board-specific, it is in the wrong file.

Perhaps I was a little too bold here.

I guess if this breaks other boards then I should leave the check for
the device type, or perhaps just drop this patch altogether.

In the latter case, the 8042 node would need to have device_type =
"8042".  This contradicts what you posted in an earlier conversation we
had regarding the 8641 device tree:

On Thu, 2007-05-17 at 01:40 +0200, Segher Boessenkool wrote:
> >>>> +                                8042@60 {
> >>>> +                                        device_type = "8042";
> >>
> >> Drop the device_type.  A number as a name isn't
> >> all that great, either.
> >
> > Currently in order for the i8042 devices to be initialized,
> > check_legacy_ioport() must find a node with device_type "8042".
> 
> So fix that :-)

This is my attempt to fix it :)

Now if you prefer that the 8042 node on the 8641 has the device_type
"8042", I will gladly add it back and drop this patch.

--Wade