From: Wade Farnsworth <wfarnsworth@mvista.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN
Date: Thu, 07 Jun 2007 09:42:45 -0700 [thread overview]
Message-ID: <1181234565.5674.182.camel@rhino> (raw)
In-Reply-To: <af3aa7bd5ff385f5ad94aa7c1d456a35@kernel.crashing.org>
On Thu, 2007-06-07 at 15:01 +0200, Segher Boessenkool wrote:
> > + /* enable superio @ 0x4e and keyboard/mouse address decoding */
> > + pci_write_config_byte(dev, 0x63, 0x90);
>
> I doubt that comment is accurate.
m1575 legacy interface device register 0x63 is the legacy I/O decoding
control.
Writing 0x90 enables ports 0x4e and 0x4f for Super I/O configuration and
ports 0x60 and 0x64 for keyboard/mouse.
>
> > + outb(0x07, 0x4e); /* device selector register */
> > + outb(0x07, 0x4f); /* select keyboard registers (device 7) */
>
> Please abstract out the 4e,4f access sequence, so
> you can just say write_sio(0x30, 1); or similar.
Sure.
>
> > + /* Enable superio runtime registers for gpio in pci i/o space */
> > + outb(0x20, 0x4e); /* device id register */
>
> This write is superfluous as far as I can see.
Yes, it appears so. I'll remove it.
--Wade
next prev parent reply other threads:[~2007-06-07 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 16:30 [PATCH] Fix the LPC47M192 SuperIO on the MPC8641 HPCN Wade Farnsworth
2007-06-06 22:39 ` Arnd Bergmann
2007-06-07 13:03 ` Segher Boessenkool
2007-06-07 16:04 ` Wade Farnsworth
2007-06-07 16:35 ` Segher Boessenkool
2007-06-07 16:51 ` Wade Farnsworth
2007-06-07 17:05 ` Segher Boessenkool
2007-06-07 20:01 ` Andy Fleming
2007-06-08 8:22 ` Segher Boessenkool
2007-06-07 13:01 ` Segher Boessenkool
2007-06-07 16:42 ` Wade Farnsworth [this message]
2007-06-07 17:04 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181234565.5674.182.camel@rhino \
--to=wfarnsworth@mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).