Re: [PATCH] powerpc: Add Marvell mv64x60 udbg putc/getc functions

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]

On Wed, 2007-06-06 at 10:29 -0700, Dale Farnsworth wrote:
> On Wed, Jun 06, 2007 at 04:06:05PM +1000, Paul Mackerras wrote:
> > Dale Farnsworth writes:
> > 
> > > Paul, this patch is unchanged from the one I posted 10 days ago.
> > > At that time, I saw no discussion, other than Mark's ACK.  I'd 
> > > argue that this is a bugfix, and hope that it could go into 2.6.22.
> > 
> > Um, it seems rather large, and in particular adds a fair bit of
> > completely new code.  Is there a simpler way of getting to an
> > acceptable point - e.g. just not use the udbg console on these boards?
> 
> Yeah, that was the first approach I took.  Unfortunately, currently the
> udbg console is included unconditionally on arch/powerpc.  I created the
> patch below to conditionalize the use of udbg console.  I thought it a
> bit risky for 2.6.22, but I think it's the right approach long term.
> 
> > If we don't have udbg support for them then the udbg console would
> > seem a bit pointless, no?
> 
> There is value in that with the udbg console we do see console output
> much earlier.  While there's some new code (I didn't think it was all
> that much), the impact is limited to the single platform now using the
> mv64x60 console port, the prpmc2800.

You don't select PPC_UDBG for any of the cell platforms, which AFAICT
means you'll break early debugging on those.

I think you should be able to do this in terms of
CONFIG_PPC_EARLY_DEBUG, which already exists.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]