linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Mark Zhan <rongkai.zhan@windriver.com>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	"paulus@samba.org" <paulus@samba.org>
Subject: Re: [PATCH 3/6] 82xx: Add the support of Wind River SBC PowerQUICCII 82xx
Date: Mon, 11 Jun 2007 15:59:36 +0800	[thread overview]
Message-ID: <1181548776.5217.18.camel@mark> (raw)
In-Reply-To: <20070609192516.092ff1b6@vitb.ru.mvista.com>

Hi Vitaly,

Since you will cover this issue, so I will remove this chunk from my
patch, and re-submit my patches.

Thanks
Mark Zhan
On Sat, 2007-06-09 at 19:25 +0400, Vitaly Bordug wrote:
> On Fri, 08 Jun 2007 16:54:38 +0800
> Mark Zhan <rongkai.zhan@windriver.com> wrote:
> 
> >  			snprintf((char*)&bus_id[(*id)], BUS_ID_SIZE, "%x:%02x",
> > -							(u32)res.start, fs_enet_data.phy_addr);
> > +				fs_enet_dev->id, fs_enet_data.phy_addr);
> > +
> >  			fs_enet_data.bus_id = (char*)&bus_id[(*id)];
> 
> Have to admit this is not correct. The issue is in fs_enet code (which should take mdio bus id, not device id), and I'll cover it.
> 

      reply	other threads:[~2007-06-11  8:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-08  8:54 [PATCH 3/6] 82xx: Add the support of Wind River SBC PowerQUICCII 82xx Mark Zhan
2007-06-09 15:25 ` Vitaly Bordug
2007-06-11  7:59   ` Mark Zhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1181548776.5217.18.camel@mark \
    --to=rongkai.zhan@windriver.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=vbordug@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).