From: Grant Likely <grant.likely@secretlab.ca>
To: Peter Korsgaard <jacmet@sunsite.dk>,
linux-usb-devel@lists.sourceforge.net,
linuxppc-embedded@ozlabs.org
Subject: [PATCH 1/6] [C67x00] Add test of active flag when checking TDs
Date: Tue, 12 Jun 2007 17:02:16 -0600 [thread overview]
Message-ID: <11816893494143-git-send-email-grant.likely@secretlab.ca> (raw)
In-Reply-To: <11816893411272-git-send-email-grant.likely@secretlab.ca>
The active flag in a TD needs to be checked to determine whether or not
the TD was processed in the frame. Without this check, the HCD assumes
the TD completed successfully, when in reality it was not processed at all.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
drivers/usb/c67x00/c67x00-sched.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/c67x00/c67x00-sched.c b/drivers/usb/c67x00/c67x00-sched.c
index 84b40a4..952bdab 100644
--- a/drivers/usb/c67x00/c67x00-sched.c
+++ b/drivers/usb/c67x00/c67x00-sched.c
@@ -1020,8 +1020,8 @@ static void check_td_list(struct c67x00_hcd *c67x00, struct pt_regs *regs)
goto cont;
}
- if ((td->status & TD_STATUSMASK_NAK) || !td_sequence_ok(td) ||
- !td_acked(td))
+ if ((td->status & TD_STATUSMASK_NAK) ||
+ !td_sequence_ok(td) || !td_acked(td) || td_active(td))
goto cont;
/* Sequence ok and acked, don't need to fix toggle */
--
1.4.4.2
next prev parent reply other threads:[~2007-06-12 23:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-12 23:02 [PATCH 0/6] Cleanups to c67x00 USB host controller driver Grant Likely
2007-06-12 23:02 ` Grant Likely [this message]
2007-06-12 23:02 ` [PATCH 2/6] [C67x00] Fix calculation of frame bandwidth Grant Likely
2007-06-12 23:02 ` [PATCH 3/6] [C67x00] Remove unnecessary references to pt_regs Grant Likely
2007-06-12 23:02 ` [PATCH 4/6] [C67x00] Added error handling paths to lowlevel interface code Grant Likely
2007-06-12 23:02 ` [PATCH 5/6] [C67x00] Change 'struct c67x00_drv' to 'struct c67x00_device' Grant Likely
2007-06-12 23:02 ` [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c Grant Likely
2007-06-13 5:58 ` Peter Korsgaard
2007-06-13 12:54 ` Grant Likely
2007-06-13 13:59 ` [linux-usb-devel] " phil culler
2007-06-13 14:33 ` Grant Likely
2007-06-13 14:37 ` Alan Stern
2007-06-13 15:09 ` Grant Likely
2007-06-13 15:43 ` Alan Stern
2007-06-13 16:19 ` Grant Likely
2007-06-13 16:38 ` Alan Stern
2007-07-30 16:51 ` I2C interrupts on 8541 Charles Krinke
2007-07-31 14:14 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11816893494143-git-send-email-grant.likely@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=jacmet@sunsite.dk \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).