From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 3/13] Abolish iopa(), mm_ptov(), io_block_mapping() from arch/powerpc From: Benjamin Herrenschmidt To: David Gibson In-Reply-To: <20070613045254.4ACC0DDE31@ozlabs.org> References: <20070613045254.4ACC0DDE31@ozlabs.org> Content-Type: text/plain Date: Sat, 16 Jun 2007 10:55:58 +1000 Message-Id: <1181955358.26853.108.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2007-06-13 at 14:52 +1000, David Gibson wrote: > These old-fashioned IO mapping functions no longer have any callers in > code which remains relevant on arch/powerpc. Therefore, this patch > removes them from arch/powerpc. I think we still want a way to setup some hand crafted BATs... maybe a special flag to pass to ioremap_flags ? It makes sense to map some heavily accessed on chip register space with a BAT on embedded. The reason I didn't like io_block_mapping() was because the virtual address was hard coded. But I don't think we should throw the baby with the bath water. If we can have it allocate the virt address using the ioremap_bot trick, that would be a good thing to keep around. Ben.