From: Wade Farnsworth <wfarnsworth@mvista.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH v2] Create add_rtc() function to enable the RTC CMOS driver
Date: Wed, 20 Jun 2007 09:21:13 -0700 [thread overview]
Message-ID: <1182356473.5674.375.camel@rhino> (raw)
In-Reply-To: <c5941587e5e4cb07efbc86845c9a15a4@kernel.crashing.org>
On Wed, 2007-06-20 at 12:06 +0200, Segher Boessenkool wrote:
> > This creates a function to register the platform device based on the
> > RTC
> > device node and verifies that the RTC port against the hard-coded value
> > in asm/mc146818rtc.h. It also sets the RTC to 24-hr mode as 12-hr mode
> > is not currently supported by the driver.
>
> The 24h thing should be set in the driver itself. Does the
> driver handle binary vs. decimal mode btw? If not, you'll
> want to do the analogue thing for that.
>
OK, I'll look into putting the 24h fix into the driver.
It looks like binary mode is also not supported, so I'll add a fix for
that as well.
Thanks,
--Wade
next prev parent reply other threads:[~2007-06-20 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 0:15 [PATCH v2] Create add_rtc() function to enable the RTC CMOS driver Wade Farnsworth
2007-06-20 10:06 ` Segher Boessenkool
2007-06-20 16:21 ` Wade Farnsworth [this message]
2007-06-20 16:59 ` [PATCH v3] " Wade Farnsworth
2007-06-20 17:46 ` Segher Boessenkool
2007-06-22 3:31 ` David Gibson
2007-06-22 7:56 ` Segher Boessenkool
2007-06-25 3:33 ` David Gibson
2007-07-10 11:54 ` Paul Mackerras
2007-07-10 16:55 ` [PATCH v4] " Wade Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1182356473.5674.375.camel@rhino \
--to=wfarnsworth@mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).