linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Andrew Morton <akpm@osdl.org>, Daniel Walker <dwalker@mvista.com>,
	john stultz <johnstul@us.ibm.com>,
	LKML <linux-kernel@vger.kernel.org>,
	LinuxPPC-dev <linuxppc-dev@ozlabs.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC] clocksouce implementation for powerpc
Date: Wed, 20 Jun 2007 19:31:21 +0200	[thread overview]
Message-ID: <1182360681.3316.25.camel@chaos> (raw)
In-Reply-To: <467961F1.1060909@ru.mvista.com>

On Wed, 2007-06-20 at 21:20 +0400, Sergei Shtylyov wrote:
> >>+void update_vsyscall(struct timespec *wall_time, struct clocksource *clock)
> >>+{
> >>+	timer_recalc_offset(tb_last_jiffy);
> >>+	timer_check_rtc();
> >>+}
> 
> > Hmm .. This doesn't look like it's taking into account that the time has
> > changed ..
> 
>     Why? By the time it gets called (form the timer softirq context) 

It is called from interrupt context at least in mainline. Only the -rt
patch moves this to the softirq.

	tglx

  reply	other threads:[~2007-06-20 17:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070616101126.296384219@inhelltoy.tec.linutronix.de>
     [not found] ` <20070616101637.107940593@inhelltoy.tec.linutronix.de>
     [not found]   ` <1182009083.11539.369.camel@imap.mvista.com>
2007-06-20  6:57     ` [RFC] clocksouce implementation for powerpc Tony Breeds
2007-06-20 14:57       ` Daniel Walker
2007-06-20 17:20         ` Sergei Shtylyov
2007-06-20 17:31           ` Thomas Gleixner [this message]
2007-06-20 18:11             ` Sergei Shtylyov
2007-06-22  6:23         ` Tony Breeds
2007-06-20 16:53       ` Sergei Shtylyov
2007-06-22  6:10         ` Tony Breeds
2007-06-22 12:42           ` Sergei Shtylyov
2007-06-20 21:06       ` john stultz
2007-06-22  6:28         ` Tony Breeds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182360681.3316.25.camel@chaos \
    --to=tglx@linutronix.de \
    --cc=akpm@osdl.org \
    --cc=dwalker@mvista.com \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).