[PATCH] Fix mpc7448hpc2 tsi108 device_type bug

[PATCH] Fix mpc7448hpc2 tsi108 device_type bug

[Zang Roy-r61911]

From: Roy Zang <tie-fei.zang@freescale.com>

Fix mpc7448hpc2 tsi108 device_type bug.
Wrong device type will break the board startup.

Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
Please apply this patch. The bug breaks the board
startup.
Please copy patches about 74xx and tsi bridge
to me.

 arch/powerpc/boot/dts/mpc7448hpc2.dts |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc7448hpc2.dts b/arch/powerpc/boot/dts/mpc7448hpc2.dts
index 0e3d314..b9158eb 100644
--- a/arch/powerpc/boot/dts/mpc7448hpc2.dts
+++ b/arch/powerpc/boot/dts/mpc7448hpc2.dts
@@ -45,7 +45,7 @@
 		#address-cells = <1>;
 		#size-cells = <1>;
 		#interrupt-cells = <2>;
-		device_type = "tsi108-bridge";
+		device_type = "tsi-bridge";
 		ranges = <00000000 c0000000 00010000>;
 		reg = <c0000000 00010000>;
 		bus-frequency = <0>;
-- 
1.5.1

Re: [PATCH] Fix mpc7448hpc2 tsi108 device_type bug

[Segher Boessenkool]

> Fix mpc7448hpc2 tsi108 device_type bug.
> Wrong device type will break the board startup.

> -		device_type = "tsi108-bridge";
> +		device_type = "tsi-bridge";

The OS code shouldn't use "device_type" at all for this,
but "compatible" instead.  You might want to fix that.
This patch is fine until you do of course.


Segher

Re: [PATCH] Fix mpc7448hpc2 tsi108 device_type bug

[Zang Roy-r61911]

On Wed, 2007-07-11 at 19:55, Segher Boessenkool wrote:
> > Fix mpc7448hpc2 tsi108 device_type bug.
> > Wrong device type will break the board startup.
> 
> > -             device_type = "tsi108-bridge";
> > +             device_type = "tsi-bridge";
> 
> The OS code shouldn't use "device_type" at all for this,
> but "compatible" instead.  You might want to fix that.
I can understand you. Should we separate it into two steps:
(1) Fix the bug in old style to ensure the  board work. I can see other
code in kernel tree will be affected by removing "device_type".
(2) Using compatible instead of device_type for all associated boards
and code.
> This patch is fine until you do of course.
That is fine.
Roy

Re: [PATCH] Fix mpc7448hpc2 tsi108 device_type bug

[Segher Boessenkool]

>>> Fix mpc7448hpc2 tsi108 device_type bug.
>>> Wrong device type will break the board startup.
>>
>>> -             device_type = "tsi108-bridge";
>>> +             device_type = "tsi-bridge";
>>
>> The OS code shouldn't use "device_type" at all for this,
>> but "compatible" instead.  You might want to fix that.
> I can understand you. Should we separate it into two steps:
> (1) Fix the bug in old style to ensure the  board work. I can see  
> other
> code in kernel tree will be affected by removing "device_type".
> (2) Using compatible instead of device_type for all associated boards
> and code.

Yes, good plan.

>> This patch is fine until you do of course.
> That is fine.

This is your step (1) :-)


Segher

Re: [PATCH] Fix mpc7448hpc2 tsi108 device_type bug

[Kumar Gala]

On Jul 11, 2007, at 1:39 AM, Zang Roy-r61911 wrote:

> From: Roy Zang <tie-fei.zang@freescale.com>
>
> Fix mpc7448hpc2 tsi108 device_type bug.
> Wrong device type will break the board startup.
>
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
> Please apply this patch. The bug breaks the board
> startup.
> Please copy patches about 74xx and tsi bridge
> to me.
>
>  arch/powerpc/boot/dts/mpc7448hpc2.dts |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/boot/dts/mpc7448hpc2.dts b/arch/powerpc/ 
> boot/dts/mpc7448hpc2.dts
> index 0e3d314..b9158eb 100644
> --- a/arch/powerpc/boot/dts/mpc7448hpc2.dts
> +++ b/arch/powerpc/boot/dts/mpc7448hpc2.dts
> @@ -45,7 +45,7 @@
>  		#address-cells = <1>;
>  		#size-cells = <1>;
>  		#interrupt-cells = <2>;
> -		device_type = "tsi108-bridge";
> +		device_type = "tsi-bridge";

Is there a reason we don't add:

                 compatible = "tsi108-bridge";

like the holly dts has?

- k

>  		ranges = <00000000 c0000000 00010000>;
>  		reg = <c0000000 00010000>;
>  		bus-frequency = <0>;
> -- 
> 1.5.1
>
>
>

Re: [PATCH] Fix mpc7448hpc2 tsi108 device_type bug

[Zang Roy-r61911]

On Thu, 2007-07-12 at 15:39, Kumar Gala wrote:
> On Jul 11, 2007, at 1:39 AM, Zang Roy-r61911 wrote:
> 
> > From: Roy Zang <tie-fei.zang@freescale.com>
> >
> > Fix mpc7448hpc2 tsi108 device_type bug.
> > Wrong device type will break the board startup.
> >
> > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> > ---
> > Please apply this patch. The bug breaks the board
> > startup.
> > Please copy patches about 74xx and tsi bridge
> > to me.
> >
> >  arch/powerpc/boot/dts/mpc7448hpc2.dts |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/mpc7448hpc2.dts b/arch/powerpc/ 
> > boot/dts/mpc7448hpc2.dts
> > index 0e3d314..b9158eb 100644
> > --- a/arch/powerpc/boot/dts/mpc7448hpc2.dts
> > +++ b/arch/powerpc/boot/dts/mpc7448hpc2.dts
> > @@ -45,7 +45,7 @@
> >               #address-cells = <1>;
> >               #size-cells = <1>;
> >               #interrupt-cells = <2>;
> > -             device_type = "tsi108-bridge";
> > +             device_type = "tsi-bridge";
> 
> Is there a reason we don't add:
> 
>                  compatible = "tsi108-bridge";
> 
> like the holly dts has?
I noticed it.
Until now, it does not affect the function.
I plan to update the mpc7448hpc2 dts file reflecting tsi109 chip.
I will add the compatible field in that patch.
Please apply this one first.
Roy