From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] Fix mpc7448hpc2 tsi108 device_type bug
Date: 11 Jul 2007 22:59:11 +0800 [thread overview]
Message-ID: <1184165950.24563.11.camel@localhost.localdomain> (raw)
In-Reply-To: <F63DA339-F5B1-40CB-B05E-9E40BEC3992E@kernel.crashing.org>
On Wed, 2007-07-11 at 19:55, Segher Boessenkool wrote:
> > Fix mpc7448hpc2 tsi108 device_type bug.
> > Wrong device type will break the board startup.
>
> > - device_type = "tsi108-bridge";
> > + device_type = "tsi-bridge";
>
> The OS code shouldn't use "device_type" at all for this,
> but "compatible" instead. You might want to fix that.
I can understand you. Should we separate it into two steps:
(1) Fix the bug in old style to ensure the board work. I can see other
code in kernel tree will be affected by removing "device_type".
(2) Using compatible instead of device_type for all associated boards
and code.
> This patch is fine until you do of course.
That is fine.
Roy
next prev parent reply other threads:[~2007-07-11 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 6:39 [PATCH] Fix mpc7448hpc2 tsi108 device_type bug Zang Roy-r61911
2007-07-11 11:55 ` Segher Boessenkool
2007-07-11 14:59 ` Zang Roy-r61911 [this message]
2007-07-11 17:51 ` Segher Boessenkool
2007-07-12 7:39 ` Kumar Gala
2007-07-12 8:17 ` Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184165950.24563.11.camel@localhost.localdomain \
--to=tie-fei.zang@freescale.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).