From: Zang Roy-r61911 <tie-fei.zang@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] Fix mpc7448hpc2 tsi108 device_type bug
Date: 12 Jul 2007 16:17:40 +0800 [thread overview]
Message-ID: <1184228259.27622.3.camel@localhost.localdomain> (raw)
In-Reply-To: <C0041903-5892-4B77-962E-A5877667BBEE@kernel.crashing.org>
On Thu, 2007-07-12 at 15:39, Kumar Gala wrote:
> On Jul 11, 2007, at 1:39 AM, Zang Roy-r61911 wrote:
>
> > From: Roy Zang <tie-fei.zang@freescale.com>
> >
> > Fix mpc7448hpc2 tsi108 device_type bug.
> > Wrong device type will break the board startup.
> >
> > Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> > ---
> > Please apply this patch. The bug breaks the board
> > startup.
> > Please copy patches about 74xx and tsi bridge
> > to me.
> >
> > arch/powerpc/boot/dts/mpc7448hpc2.dts | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/mpc7448hpc2.dts b/arch/powerpc/
> > boot/dts/mpc7448hpc2.dts
> > index 0e3d314..b9158eb 100644
> > --- a/arch/powerpc/boot/dts/mpc7448hpc2.dts
> > +++ b/arch/powerpc/boot/dts/mpc7448hpc2.dts
> > @@ -45,7 +45,7 @@
> > #address-cells = <1>;
> > #size-cells = <1>;
> > #interrupt-cells = <2>;
> > - device_type = "tsi108-bridge";
> > + device_type = "tsi-bridge";
>
> Is there a reason we don't add:
>
> compatible = "tsi108-bridge";
>
> like the holly dts has?
I noticed it.
Until now, it does not affect the function.
I plan to update the mpc7448hpc2 dts file reflecting tsi109 chip.
I will add the compatible field in that patch.
Please apply this one first.
Roy
prev parent reply other threads:[~2007-07-12 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 6:39 [PATCH] Fix mpc7448hpc2 tsi108 device_type bug Zang Roy-r61911
2007-07-11 11:55 ` Segher Boessenkool
2007-07-11 14:59 ` Zang Roy-r61911
2007-07-11 17:51 ` Segher Boessenkool
2007-07-12 7:39 ` Kumar Gala
2007-07-12 8:17 ` Zang Roy-r61911 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184228259.27622.3.camel@localhost.localdomain \
--to=tie-fei.zang@freescale.com \
--cc=david@gibson.dropbear.id.au \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).