From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-scsi@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Alessandro Rubini <rubini@vision.unipv.it>,
Linux/PPC Development <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver
Date: Tue, 17 Jul 2007 07:38:48 +1000 [thread overview]
Message-ID: <1184621929.25235.79.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.62.0707161515460.1072@pademelon.sonytel.be>
> Upon closer look, while flush_kernel_dcache_page() is a no-op on ppc64,
> flush_dcache_page() isn't. So I'd prefer to not call it if not really needed.
>
> And according to James, flush_kernel_dcache_page() should be sufficient...
>
> So I'm getting puzzled again...
flush_dcache_page() handles icache vs. dcache coherency by clearing the
PG_arch_1 bit in the struct page that indicates that the page is cache
clean.
You -must- call it if you're going to use any form of CPU access to
write to the page (basically dirtying the data cache) and that page can
be ever mapped into user space and executed from.
I don't know what flush_kernel_dcache_page() does and if it needs a
similar treatement, it's a new interface, so maybe Jens and or James can
tell me more about it..
Cheers,
Ben.
next prev parent reply other threads:[~2007-07-16 21:39 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 13:22 [patch 0/6] PS3 Storage Drivers for 2.6.23, take 4 Geert Uytterhoeven
2007-07-04 13:22 ` [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver Geert Uytterhoeven
2007-07-04 13:22 ` [patch 2/6] ps3: Storage Driver Core Geert Uytterhoeven
2007-07-04 13:22 ` [patch 3/6] ps3: Storage device registration routines Geert Uytterhoeven
2007-07-04 13:22 ` [patch 4/6] ps3: Disk Storage Driver Geert Uytterhoeven
2007-07-04 13:22 ` [patch 5/6] ps3: BD/DVD/CD-ROM " Geert Uytterhoeven
2007-07-13 13:02 ` James Bottomley
2007-07-13 13:05 ` Jens Axboe
2007-07-13 13:25 ` Geert Uytterhoeven
2007-07-13 13:34 ` James Bottomley
2007-07-13 13:45 ` Geert Uytterhoeven
2007-07-13 14:02 ` James Bottomley
2007-07-13 14:19 ` Arnd Bergmann
2007-07-13 15:10 ` Geert Uytterhoeven
2007-07-13 15:28 ` James Bottomley
2007-07-13 20:13 ` Geert Uytterhoeven
2007-07-16 11:43 ` Geert Uytterhoeven
2007-07-16 12:16 ` Jens Axboe
2007-07-16 12:59 ` Geert Uytterhoeven
2007-07-16 13:04 ` Jens Axboe
2007-07-16 13:24 ` Geert Uytterhoeven
2007-07-16 13:33 ` Jens Axboe
2007-07-16 21:38 ` Benjamin Herrenschmidt [this message]
2007-07-16 13:47 ` James Bottomley
2007-07-16 14:38 ` Jens Axboe
2007-07-16 14:59 ` Geert Uytterhoeven
2007-07-16 21:40 ` Benjamin Herrenschmidt
2007-07-16 21:49 ` Benjamin Herrenschmidt
2007-07-16 22:03 ` James Bottomley
2007-07-16 22:12 ` Benjamin Herrenschmidt
2007-07-13 16:35 ` Jens Axboe
2007-07-13 23:12 ` Benjamin Herrenschmidt
2007-07-16 12:08 ` Segher Boessenkool
2007-07-13 14:51 ` Jens Axboe
2007-07-13 23:06 ` Benjamin Herrenschmidt
2007-07-04 13:22 ` [patch 6/6] ps3: FLASH ROM " Geert Uytterhoeven
2007-07-10 7:45 ` [patch 0/6] PS3 Storage Drivers for 2.6.23, take 4 Geert Uytterhoeven
2007-07-10 7:55 ` Jens Axboe
2007-07-10 8:01 ` Paul Mackerras
2007-07-10 8:32 ` Jens Axboe
2007-07-13 9:31 ` Geert Uytterhoeven
2007-07-13 12:27 ` PS3 Storage Driver O_DIRECT issue Olaf Hering
2007-07-13 13:34 ` Geert Uytterhoeven
2007-07-17 16:40 ` Geoff Levand
2007-07-18 16:12 ` Geert Uytterhoeven
2007-07-18 17:57 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2007-06-21 14:14 [patch 0/6] PS3 Storage Drivers for 2.6.23, take 3 Geert Uytterhoeven
2007-06-21 14:14 ` [patch 5/6] ps3: BD/DVD/CD-ROM Storage Driver Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184621929.25235.79.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=James.Bottomley@SteelEye.com \
--cc=arnd@arndb.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=rubini@vision.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).