linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* possible dead CONFIG-related content under arch/powerpc
@ 2007-07-14 22:19 Robert P. J. Day
  2007-07-16  9:16 ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Robert P. J. Day @ 2007-07-14 22:19 UTC (permalink / raw)
  To: Linux PPC Mailing List


  not sure if this is still the right ML, but here's the equivalent
unreferenced content under arch/powerpc:

========== FC_ENET_HAS_SCC ==========
arch/powerpc/platforms/8xx/mpc885ads_setup.c:109:#ifndef CONFIG_FC_ENET_HAS_SCC
========== SMP_750 ==========
arch/ppc/mm/tlb.c:92:#ifdef CONFIG_SMP_750
arch/powerpc/mm/tlb_32.c:92:#ifdef CONFIG_SMP_750
========== SPE_BASE ==========
arch/powerpc/mm/hash_utils_64.c:612:#ifdef CONFIG_SPE_BASE
arch/powerpc/mm/hash_utils_64.c:747:#ifdef CONFIG_SPE_BASE

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: possible dead CONFIG-related content under arch/powerpc
  2007-07-14 22:19 possible dead CONFIG-related content under arch/powerpc Robert P. J. Day
@ 2007-07-16  9:16 ` Geert Uytterhoeven
  2007-07-16 13:05   ` Michael Ellerman
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2007-07-16  9:16 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux PPC Mailing List

[-- Attachment #1: Type: TEXT/PLAIN, Size: 852 bytes --]

On Sat, 14 Jul 2007, Robert P. J. Day wrote:
> ========== SPE_BASE ==========
> arch/powerpc/mm/hash_utils_64.c:612:#ifdef CONFIG_SPE_BASE
> arch/powerpc/mm/hash_utils_64.c:747:#ifdef CONFIG_SPE_BASE

Interesting, should this one be CONFIG_SPU_BASE?

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: possible dead CONFIG-related content under arch/powerpc
  2007-07-16  9:16 ` Geert Uytterhoeven
@ 2007-07-16 13:05   ` Michael Ellerman
  2007-07-16 16:35     ` [PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc) Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2007-07-16 13:05 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux PPC Mailing List, Robert P. J. Day

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Mon, 2007-07-16 at 11:16 +0200, Geert Uytterhoeven wrote:
> On Sat, 14 Jul 2007, Robert P. J. Day wrote:
> > ========== SPE_BASE ==========
> > arch/powerpc/mm/hash_utils_64.c:612:#ifdef CONFIG_SPE_BASE
> > arch/powerpc/mm/hash_utils_64.c:747:#ifdef CONFIG_SPE_BASE
> 
> Interesting, should this one be CONFIG_SPU_BASE?

Yes, ouch.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc)
  2007-07-16 13:05   ` Michael Ellerman
@ 2007-07-16 16:35     ` Geert Uytterhoeven
  2007-07-16 21:50       ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2007-07-16 16:35 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Linux PPC Mailing List, Robert P. J. Day

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1528 bytes --]

The config symbol for SPE support is called CONFIG_SPU_BASE, not
CONFIG_SPE_BASE.

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>

diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index 4f2f453..0b25d42 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -609,7 +609,7 @@ static void demote_segment_4k(struct mm_struct *mm, unsigned long addr)
 	mm->context.sllp = SLB_VSID_USER | mmu_psize_defs[MMU_PAGE_4K].sllp;
 #endif /* CONFIG_PPC_MM_SLICES */
 
-#ifdef CONFIG_SPE_BASE
+#ifdef CONFIG_SPU_BASE
 	spu_flush_all_slbs(mm);
 #endif
 }
@@ -744,7 +744,7 @@ int hash_page(unsigned long ea, unsigned long access, unsigned long trap)
 			       "to 4kB pages because of "
 			       "non-cacheable mapping\n");
 			psize = mmu_vmalloc_psize = MMU_PAGE_4K;
-#ifdef CONFIG_SPE_BASE
+#ifdef CONFIG_SPU_BASE
 			spu_flush_all_slbs(mm);
 #endif
 		}

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc)
  2007-07-16 16:35     ` [PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc) Geert Uytterhoeven
@ 2007-07-16 21:50       ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 5+ messages in thread
From: Benjamin Herrenschmidt @ 2007-07-16 21:50 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Linux PPC Mailing List, Robert P. J. Day, Arnd Bergmann

On Mon, 2007-07-16 at 18:35 +0200, Geert Uytterhoeven wrote:
> The config symbol for SPE support is called CONFIG_SPU_BASE, not
> CONFIG_SPE_BASE.

Oops... Arnd, we need to check the distro kernels here.

> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
> index 4f2f453..0b25d42 100644
> --- a/arch/powerpc/mm/hash_utils_64.c
> +++ b/arch/powerpc/mm/hash_utils_64.c
> @@ -609,7 +609,7 @@ static void demote_segment_4k(struct mm_struct *mm, unsigned long addr)
>  	mm->context.sllp = SLB_VSID_USER | mmu_psize_defs[MMU_PAGE_4K].sllp;
>  #endif /* CONFIG_PPC_MM_SLICES */
>  
> -#ifdef CONFIG_SPE_BASE
> +#ifdef CONFIG_SPU_BASE
>  	spu_flush_all_slbs(mm);
>  #endif
>  }
> @@ -744,7 +744,7 @@ int hash_page(unsigned long ea, unsigned long access, unsigned long trap)
>  			       "to 4kB pages because of "
>  			       "non-cacheable mapping\n");
>  			psize = mmu_vmalloc_psize = MMU_PAGE_4K;
> -#ifdef CONFIG_SPE_BASE
> +#ifdef CONFIG_SPU_BASE
>  			spu_flush_all_slbs(mm);
>  #endif
>  		}
> 
> With kind regards,
>  
> Geert Uytterhoeven
> Software Architect
> 
> Sony Network and Software Technology Center Europe
> The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
>  
> Phone:    +32 (0)2 700 8453	
> Fax:      +32 (0)2 700 8622	
> E-mail:   Geert.Uytterhoeven@sonycom.com	
> Internet: http://www.sony-europe.com/
>  	
> Sony Network and Software Technology Center Europe	
> A division of Sony Service Centre (Europe) N.V.	
> Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
> VAT BE 0413.825.160 · RPR Brussels	
> Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
> _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-07-16 21:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-14 22:19 possible dead CONFIG-related content under arch/powerpc Robert P. J. Day
2007-07-16  9:16 ` Geert Uytterhoeven
2007-07-16 13:05   ` Michael Ellerman
2007-07-16 16:35     ` [PATCH] cell: CONFIG_SPE_BASE is a typo (was: Re: possible dead CONFIG-related content under arch/powerpc) Geert Uytterhoeven
2007-07-16 21:50       ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).